Merged
Conversation
nreese
added a commit
that referenced
this pull request
Oct 9, 2019
…ic#46631) * [Maps] tooltip custom labels * add drag handlers for re-ordering tooltip property order * add trash button to remove property * add jest tests for AddTooltipFieldPopover * sort EMS file tooltip properties * update TooltipSelector jest test * clean up AddTooltipFieldPopover field sorting * remove console statements * add more styles when row is getting dragged * change reorder aria label * move css changes into seperate file * allow adding multiple fields before closing popover * clear checked state on Add * update jest snapshots * use FieldIcon to display field type as icon * add bottom border to tooltip field * avoid flash after drag and drop * Tooltip styles (#32) * update TooltipSelector snapshot * replace 24px with
nreese
added a commit
that referenced
this pull request
Oct 10, 2019
…ic#46631) * [Maps] tooltip custom labels * add drag handlers for re-ordering tooltip property order * add trash button to remove property * add jest tests for AddTooltipFieldPopover * sort EMS file tooltip properties * update TooltipSelector jest test * clean up AddTooltipFieldPopover field sorting * remove console statements * add more styles when row is getting dragged * change reorder aria label * move css changes into seperate file * allow adding multiple fields before closing popover * clear checked state on Add * update jest snapshots * use FieldIcon to display field type as icon * add bottom border to tooltip field * avoid flash after drag and drop * Tooltip styles (#32) * update TooltipSelector snapshot * replace 24px with
nreese
added a commit
that referenced
this pull request
Oct 11, 2019
…ic#46631) (elastic#47771) * [Maps] tooltip custom labels * add drag handlers for re-ordering tooltip property order * add trash button to remove property * add jest tests for AddTooltipFieldPopover * sort EMS file tooltip properties * update TooltipSelector jest test * clean up AddTooltipFieldPopover field sorting * remove console statements * add more styles when row is getting dragged * change reorder aria label * move css changes into seperate file * allow adding multiple fields before closing popover * clear checked state on Add * update jest snapshots * use FieldIcon to display field type as icon * add bottom border to tooltip field * avoid flash after drag and drop * Tooltip styles (#32) * update TooltipSelector snapshot * replace 24px with
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just improved some styles and fixed the sasslint errors.