Fix the lifetime of progam_iter items#82
Merged
nrc merged 1 commit intonrc:masterfrom Nov 3, 2023
teskje:fix-program-iter-lifetime
Merged
Fix the lifetime of progam_iter items#82nrc merged 1 commit intonrc:masterfrom teskje:fix-program-iter-lifetime
progam_iter items#82nrc merged 1 commit intonrc:masterfrom
teskje:fix-program-iter-lifetime
Conversation
The `ProgramHeader` objects produced by `ElfFile::program_iter` should have the same lifetime as the `ElfFile`, i.e. the lifetime of the input data. Prior to this commit, they instead had the shorter of a) the `ElfFile` lifetime and b) the `&self` reference lifetime, making code dealing with these `ProgramHeader`s awkward to write. This commit fixes the lifetime issue by making the lifetime annotations the same as for `ElfFile::section_iter`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ProgramHeaderobjects produced byElfFile::program_itershould have the same lifetime as theElfFile, i.e. the lifetime of the input data. Prior to this PR, they instead had the shorter of a) theElfFilelifetime and b) the&selfreference lifetime, making code dealing with theseProgramHeaders awkward to write.This PR fixes the lifetime issue by making the lifetime annotations the same as for
ElfFile::section_iter.It seems like the issue was originally introduced in #69. That PR also annotates
section_itercorrectly, so I'm unsure why a different approach was chosen forprogram_iter.