Fixed logical mistake #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` //let xr = &mut x; // Error - there is already an immutable ref, so we ``` Should be xr1 (or any other name here), with just xr it will compile just fine
nrc
reviewed
Apr 30, 2023
Owner
nrc
left a comment
nrc
left a comment
There was a problem hiding this comment.
Thanks for catching this! To make the error, I think it also needs a usage of xr after the creation of xr1 in order to keep xr alive long enough
| //let xr = &mut x; // Error - there is already an immutable ref, so we | ||
| //let xr1 = &mut x; // Error - there is already an immutable ref, so we | ||
| // can't make a mutable one | ||
|
|
Owner
There was a problem hiding this comment.
To make this actually error, we need another call to bar(xr) in here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be xr1 (or any other name here), with xr it will compile just fine