Skip to content

fix(cli): cli windows compat #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 3 commits into from
Feb 4, 2026
Merged

fix(cli): cli windows compat #942

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b45b56
fix(cli): enable shell for npm on windows
RYGRIT Feb 4, 2026
1464ac2
Merge branch 'main' into fix/cli-windows-compat
RYGRIT Feb 4, 2026
e3d2a14
Merge branch 'main' into fix/cli-windows-compat
danielroe Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cli/src/npm-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,12 @@ async function execNpm(

try {
// Use execFile instead of exec to avoid shell injection vulnerabilities
// execFile does not spawn a shell, so metacharacters are passed literally
// On Windows, shell: true is required to execute .cmd files (like npm.cmd)
// On Unix, we keep it false for better security and performance
const { stdout, stderr } = await execFileAsync('npm', npmArgs, {
timeout: 60000,
env: { ...process.env, FORCE_COLOR: '0' },
shell: process.platform === 'win32',
})

if (!options.silent) {
Expand Down Expand Up @@ -386,6 +388,7 @@ export async function packageInit(
timeout: 60000,
cwd: tempDir,
env: { ...process.env, FORCE_COLOR: '0' },
shell: process.platform === 'win32',
})

logSuccess(`Published ${name}@0.0.0`)
Expand Down
Loading