Skip to content

fix: display tooltips on focus for install size + create command #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 2 commits into from
Feb 4, 2026
Merged

fix: display tooltips on focus for install size + create command #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f30d58
fix: display tooltips on focus for install size + create command
danielroe Feb 4, 2026
59bcd6c
chore: be consistent in all things
danielroe Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions app/components/Terminal/Install.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,20 +200,19 @@ const copyCreateCommand = () => copyCreate(getFullCreateCommand())
<span class="text-fg-subtle font-mono text-sm select-none"
># {{ $t('package.create.title') }}</span
>
<NuxtLink
:to="`/package/${createPackageInfo.packageName}`"
class="text-fg-muted hover:text-fg text-xs transition-colors focus-visible:outline-accent/70 rounded"
:title="$t('package.create.view', { packageName: createPackageInfo.packageName })"
<TooltipApp
:text="$t('package.create.view', { packageName: createPackageInfo.packageName })"
>
<TooltipApp
:text="$t('package.create.view', { packageName: createPackageInfo.packageName })"
<NuxtLink
:to="`/package/${createPackageInfo.packageName}`"
class="inline-flex items-center justify-center min-w-6 min-h-6 -m-1 p-1 text-fg-muted hover:text-fg text-xs transition-colors focus-visible:outline-2 focus-visible:outline-accent/70 rounded"
>
<span class="i-carbon:information w-3 h-3 mt-1" aria-hidden="true" />
</TooltipApp>
<span class="sr-only">{{
$t('package.create.view', { packageName: createPackageInfo.packageName })
}}</span>
</NuxtLink>
<span class="i-carbon:information w-3 h-3" aria-hidden="true" />
<span class="sr-only">{{
$t('package.create.view', { packageName: createPackageInfo.packageName })
}}</span>
</NuxtLink>
</TooltipApp>
</div>

<div
Expand Down
7 changes: 6 additions & 1 deletion app/pages/package/[...package].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,7 +863,12 @@ defineOgImageComponent('Package', {
<dt class="text-xs text-fg-subtle uppercase tracking-wider flex items-center gap-1">
{{ $t('package.stats.install_size') }}
<TooltipApp :text="sizeTooltip">
<span class="i-carbon:information w-3 h-3 text-fg-subtle" aria-hidden="true" />
<span
tabindex="0"
class="inline-flex items-center justify-center min-w-6 min-h-6 -m-1 p-1 text-fg-subtle cursor-help focus-visible:outline-2 focus-visible:outline-accent/70 rounded"
>
<span class="i-carbon:information w-3 h-3" aria-hidden="true" />
</span>
</TooltipApp>
</dt>
<dd class="font-mono text-sm text-fg">
Expand Down
Loading