Skip to content

fix(i18n,ui): add search page title and description #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 2 commits into from
Feb 3, 2026
Merged

fix(i18n,ui): add search page title and description #872

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbd7151
feat(i18n, ui): add search page title and description
userquin Feb 3, 2026
1aa65f6
chore: use same title at `defineOgImageComponent `
userquin Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions app/pages/search.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,12 +581,20 @@ function handleResultsKeydown(e: KeyboardEvent) {
onKeyDown(['ArrowDown', 'ArrowUp', 'Enter'], handleResultsKeydown)

useSeoMeta({
title: () => (query.value ? `Search: ${query.value} - npmx` : 'Search Packages - npmx'),
title: () =>
`${query.value ? $t('search.title_search', { search: query.value }) : $t('search.title_packages')} - npmx`,
description: () =>
query.value
? $t('search.meta_description', { search: query.value })
: $t('search.meta_description_packages'),
})

defineOgImageComponent('Default', {
title: 'npmx',
Comment thread
userquin marked this conversation as resolved.
Outdated
description: () => (query.value ? `Search results for "${query.value}"` : 'Search npm packages'),
description: () =>
query.value
? $t('search.meta_description', { search: query.value })
: $t('search.meta_description_packages'),
primaryColor: '#60a5fa',
})
</script>
Expand Down
4 changes: 4 additions & 0 deletions i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
"updating": "(updating...)",
"no_results": "No packages found for \"{query}\"",
"title": "search",
"title_search": "search: {search}",
"title_packages": "search packages",
"meta_description": "Search results for '{search}'",
"meta_description_packages": "Search npm packages",
"not_taken": "{name} is not taken",
"claim_prompt": "Claim this package name on npm",
"claim_button": "Claim \"{name}\"",
Expand Down
4 changes: 4 additions & 0 deletions i18n/locales/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
"updating": "(actualizando...)",
"no_results": "No se encontraron paquetes para \"{query}\"",
"title": "búsqueda",
"title_search": "búsqueda: {search}",
"title_packages": "búsqueda de paquetes",
"meta_description": "Resultado de la búsqueda para '{search}'",
"meta_description_packages": "Búsqueda de paquetes npm",
"not_taken": "{name} no está ocupado",
"claim_prompt": "Reclamar este nombre de paquete en npm",
"claim_button": "Reclamar \"{name}\"",
Expand Down
4 changes: 4 additions & 0 deletions lunaria/files/en-GB.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
"updating": "(updating...)",
"no_results": "No packages found for \"{query}\"",
"title": "search",
"title_search": "search: {search}",
"title_packages": "search packages",
"meta_description": "Search results for '{search}'",
"meta_description_packages": "Search npm packages",
"not_taken": "{name} is not taken",
"claim_prompt": "Claim this package name on npm",
"claim_button": "Claim \"{name}\"",
Expand Down
4 changes: 4 additions & 0 deletions lunaria/files/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
"updating": "(updating...)",
"no_results": "No packages found for \"{query}\"",
"title": "search",
"title_search": "search: {search}",
"title_packages": "search packages",
"meta_description": "Search results for '{search}'",
"meta_description_packages": "Search npm packages",
"not_taken": "{name} is not taken",
"claim_prompt": "Claim this package name on npm",
"claim_button": "Claim \"{name}\"",
Expand Down
4 changes: 4 additions & 0 deletions lunaria/files/es-419.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
"updating": "(actualizando...)",
"no_results": "No se encontraron paquetes para \"{query}\"",
"title": "búsqueda",
"title_search": "búsqueda: {search}",
"title_packages": "búsqueda de paquetes",
"meta_description": "Resultado de la búsqueda para '{search}'",
"meta_description_packages": "Búsqueda de paquetes npm",
"not_taken": "{name} no está ocupado",
"claim_prompt": "Reclamar este nombre de paquete en npm",
"claim_button": "Reclamar \"{name}\"",
Expand Down
4 changes: 4 additions & 0 deletions lunaria/files/es-ES.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
"updating": "(actualizando...)",
"no_results": "No se encontraron paquetes para \"{query}\"",
"title": "búsqueda",
"title_search": "búsqueda: {search}",
"title_packages": "búsqueda de paquetes",
"meta_description": "Resultado de la búsqueda para '{search}'",
"meta_description_packages": "Búsqueda de paquetes npm",
"not_taken": "{name} no está ocupado",
"claim_prompt": "Reclamar este nombre de paquete en npm",
"claim_button": "Reclamar \"{name}\"",
Expand Down