refactor: use timers/promises setTimeout for async delays#2377
refactor: use timers/promises setTimeout for async delays#2377ghostdevv merged 1 commit intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis pull request standardises asynchronous delay handling across the codebase by replacing manually defined Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔗 Linked issue
N/A
🧭 Context
This change replaces ad-hoc promise wrappers around
setTimeoutwith Node’s promise-based timer API fromnode:timers/promises.The goal is to remove repetitive delay boilerplate and make retry/wait paths easier to read without changing behavior.
📚 Description
Updated the async delay calls that were written as
new Promise(resolve => setTimeout(resolve, ms))to usesetTimeout(ms)fromnode:timers/promisesinstead.This affects the GitHub contributors evolution retry logic, the Upstash OAuth lock retry path, and the related unit tests. The behavior is unchanged; this is a small refactor toward the standard Node API for promise-based timers.