refactor: replace tinyglobby with Node.js built-in glob APIs#2375
refactor: replace tinyglobby with Node.js built-in glob APIs#2375ghostdevv merged 4 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughReplaces runtime file-globbing from the tinyglobby package with Node.js built-in glob APIs. In modules/blog.ts, synchronous tinyglobby usage was removed in favour of async Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Local testing in $ node
Welcome to Node.js v24.14.1.
Type ".help" for more information.
> const tinyglobby = require("tinyglobby");
undefined
> tinyglobby.globSync('blog/*.md'.replace(/\\/g, '/'))
[ 'blog/alpha-release.md', 'blog/first-post.md' ]
> const fs = require("fs");
undefined
> fs.globSync('*.md', { cwd: "blog" }).map(file => `blog/${file}`)
[ 'blog/alpha-release.md', 'blog/first-post.md' ] |
🔗 Linked issue
N/A
🧭 Context
The codebase still used
tinyglobbydirectly in a couple of Node-only module paths, even though the project now targets Node.js 24.x and already uses Node’s built-in glob APIs elsewhere. That left an unnecessary direct dependency and two code paths that could be simplified with platform APIs.📚 Description
This PR replaces the remaining direct
tinyglobbyusage with Node’s built-in glob APIs.