refactor(cli)!: use mkdtempDisposable and require node >=24.4#2365
refactor(cli)!: use mkdtempDisposable and require node >=24.4#2365ghostdevv merged 3 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I updated the engines field, I think we can get away with this since we're in pre-release :p |
🔗 Linked issue
N/A
🧭 Context
The connector’s
packageInit()flow created a temporary directory withmkdtemp()and then manually removed it in afinallyblock. Since this codebase now runs on Node.js 24.x, we can use the built-in disposable temp directory API instead of managing that cleanup ourselves.📚 Description
This PR updates the CLI package init flow to use
fs.promises.mkdtempDisposable()withawait usinginpackageInit().