feat: add logo to OAuth metadata#2355
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes add a 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2a6d153 to
f50f110
Compare
| ? webUriSchema.parse(`${clientUri}/.well-known/jwks.json`) | ||
| : undefined | ||
|
|
||
| // If anything changes here, please make sure to also update /shared/schemas/oauth.ts to match |
There was a problem hiding this comment.
This file does not exist anymore
f50f110 to
1772fb2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔗 Linked issue
🧭 Context
When I go in my PDS's account management and look at the connected apps, npmx.dev has no logo. For comparison, PDSls has one:

(npmx is missing in the screenshot because right now I'm getting error 401 when trying to log in)
The difference seems to be that https://pdsls.dev/oauth-client-metadata.json links to a logo while https://npmx.dev/oauth-client-metadata.json does not.
📚 Description
This PR adds a logo_uri set to npmx.dev/logo.svg. I'm not 100% sure that SVG is a supported format and I don't know how to test it, I guess if we merge and it does not work then we switch to .ico like PDSls? 😅