Skip to content

feat: add logo to OAuth metadata#2355

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
nicolo-ribaudo:oauth-add-logo
Apr 1, 2026
Merged

feat: add logo to OAuth metadata#2355
ghostdevv merged 1 commit intonpmx-dev:mainfrom
nicolo-ribaudo:oauth-add-logo

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Contributor

🔗 Linked issue

🧭 Context

When I go in my PDS's account management and look at the connected apps, npmx.dev has no logo. For comparison, PDSls has one:
image

(npmx is missing in the screenshot because right now I'm getting error 401 when trying to log in)

The difference seems to be that https://pdsls.dev/oauth-client-metadata.json links to a logo while https://npmx.dev/oauth-client-metadata.json does not.

📚 Description

This PR adds a logo_uri set to npmx.dev/logo.svg. I'm not 100% sure that SVG is a supported format and I don't know how to test it, I guess if we merge and it does not work then we switch to .ico like PDSls? 😅

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 1, 2026 10:44am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 1, 2026 10:44am
npmx-lunaria Ignored Ignored Apr 1, 2026 10:44am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4ff7e46c-0d32-4b2a-ba89-434bd1a078b9

📥 Commits

Reviewing files that changed from the base of the PR and between 2af4011 and 2a6d153.

📒 Files selected for processing (2)
  • server/utils/atproto/oauth.ts
  • shared/schemas/oauth.ts

📝 Walkthrough

Walkthrough

The changes add a logo\\_uri field to the OAuth client metadata system across two files. The utility function in server/utils/atproto/oauth.ts now includes logo\\_uri set to ${client\\_uri}/logo.svg within the returned OAuth client metadata. Correspondingly, the schema definition in shared/schemas/oauth.ts was updated to include logo\\_uri as a validated string field constrained to URL format using pipe(string(), url()). These modifications extend the OAuth metadata structure to support logo URIs.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly explains the problem (missing logo in OAuth metadata), provides context with a screenshot comparison, and describes the solution being implemented.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch oauth-add-logo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

? webUriSchema.parse(`${clientUri}/.well-known/jwks.json`)
: undefined

// If anything changes here, please make sure to also update /shared/schemas/oauth.ts to match
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file does not exist anymore

@nicolo-ribaudo nicolo-ribaudo changed the title Add logo to OAuth metadata feat: Add logo to OAuth metadata Apr 1, 2026
@nicolo-ribaudo nicolo-ribaudo changed the title feat: Add logo to OAuth metadata feat: add logo to OAuth metadata Apr 1, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv added this pull request to the merge queue Apr 1, 2026
Merged via the queue into npmx-dev:main with commit 6b5b847 Apr 1, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants