Skip to content

docs(ui): add stories for Accessibility page#2301

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
cylewaitforit:sb-accessibility-page
Mar 28, 2026
Merged

docs(ui): add stories for Accessibility page#2301
ghostdevv merged 1 commit intonpmx-dev:mainfrom
cylewaitforit:sb-accessibility-page

Conversation

@cylewaitforit
Copy link
Copy Markdown
Contributor

@cylewaitforit cylewaitforit commented Mar 28, 2026

🔗 Linked issue

#2150

🧭 Context

This would also enable a storybook mock page, storybook a11y checks, and chromatic visual regression tests for this page as documented by the storybook stories.

📚 Description

Adds stories file for Accessibility page.

Adjusts font loading in the storybook to match app pages.

https://698b88d5157d89f1f33a6c21-kwcgqgjvfx.chromatic.com/?path=/story/pages-accessibility--default

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 28, 2026 1:34am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 28, 2026 1:34am
npmx-lunaria Ignored Ignored Mar 28, 2026 1:34am

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2b74f086-c0cc-4d11-8c89-57bdccbaae33

📥 Commits

Reviewing files that changed from the base of the PR and between bfc0917 and eba95db.

📒 Files selected for processing (3)
  • .storybook/main.ts
  • .storybook/preview-head.html
  • app/pages/accessibility.stories.ts

📝 Walkthrough

Walkthrough

This pull request modifies Storybook configuration and adds a new story file. The .storybook/main.ts file is updated to serve static assets from an additional source directory with path rewriting. The .storybook/preview-head.html file receives font-face declarations for Geist typeface families alongside styling improvements for text rendering and font smoothing. A new story file is introduced at app/pages/accessibility.stories.ts that registers the Accessibility component within a page layout scaffold containing header, footer, and content wrapper elements.

Possibly related PRs

Suggested reviewers

  • ghostdevv
  • alexdln
  • JReinhold
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly addresses the changeset by explaining the addition of a Storybook stories file for the Accessibility page and adjustments to font loading in Storybook.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment on lines +2 to +3
/* Load Geist fonts to match the production app (normally handled by @nuxt/fonts,
which is disabled in Storybook at this time) */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come?

@ghostdevv ghostdevv added this pull request to the merge queue Mar 28, 2026
Merged via the queue into npmx-dev:main with commit 18db337 Mar 28, 2026
23 checks passed
@github-actions github-actions bot mentioned this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants