Skip to content

chore: improve externals configuration in chromatic#2261

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
JReinhold:fix-chromatic-cache
Mar 24, 2026
Merged

chore: improve externals configuration in chromatic#2261
ghostdevv merged 1 commit intonpmx-dev:mainfrom
JReinhold:fix-chromatic-cache

Conversation

@JReinhold
Copy link
Collaborator

🔗 Linked issue

🧭 Context

To cut down on Chromatic snapshot usage, we're trying to be more aggressive about not cache busting as often. Currently changes to nuxt.config.ts and app/assets/main.css accounts for over 5000 snapshots a week, which are most likely not necessary.

If we see that the cache is now busted to rarely, we can continue iterating on this.

📚 Description

@vercel
Copy link

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 24, 2026 3:19pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 24, 2026 3:19pm
npmx-lunaria Ignored Ignored Mar 24, 2026 3:19pm

Request Review

@JReinhold JReinhold self-assigned this Mar 24, 2026
@JReinhold JReinhold requested a review from ghostdevv March 24, 2026 12:31
@JReinhold JReinhold moved this to In Progress in Core Team Projects Mar 24, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 318c84ca-6122-4f7f-ae15-3876fa9ad188

📥 Commits

Reviewing files that changed from the base of the PR and between 84a7fc9 and edd9627.

📒 Files selected for processing (1)
  • chromatic.config.json

📝 Walkthrough

Walkthrough

This pull request modifies the chromatic.config.json file to update the externals configuration list. Specifically, it removes public/** and app/assets/** from the externals definition, whilst retaining .storybook/** and uno.config.ts. The configuration changes are minimal, affecting only one line net change in the file. No other configuration fields or exported entities are altered.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description provides clear context about reducing Chromatic snapshot usage by adjusting externals configuration, directly relating to the changeset in chromatic.config.json.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@cylewaitforit cylewaitforit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JReinhold !

I had to move the theme out of uno.config.ts in #2252. So depending on if this merges before or after I will probably add uno.theme.ts to this array soon. I think we would want to bust cache on changes to either file but I imagine that neither file would really change all that often though.

Copy link
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@ghostdevv ghostdevv force-pushed the fix-chromatic-cache branch from ad12269 to edd9627 Compare March 24, 2026 15:18
@ghostdevv

This comment was marked as resolved.

@ghostdevv ghostdevv added this pull request to the merge queue Mar 24, 2026
Merged via the queue into npmx-dev:main with commit 017ec72 Mar 24, 2026
33 of 35 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Core Team Projects Mar 24, 2026
@ghostdevv
Copy link
Contributor

Thanks @JReinhold !

I had to move the theme out of uno.config.ts in #2252. So depending on if this merges before or after I will probably add uno.theme.ts to this array soon. I think we would want to bust cache on changes to either file but I imagine that neither file would really change all that often though.

I just merged your PR with main and added the change there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants