Skip to content

feat(i18n): add Austrian translation#2260

Merged
ghostdevv merged 4 commits intonpmx-dev:mainfrom
trueberryless:feat/i18n-at
Mar 24, 2026
Merged

feat(i18n): add Austrian translation#2260
ghostdevv merged 4 commits intonpmx-dev:mainfrom
trueberryless:feat/i18n-at

Conversation

@trueberryless
Copy link
Contributor

🧭 Context

The Austrian and German language have some little differences here and there, that's why I decided to add support for the Austrian language.

📚 Description

I moved all de-DE strings to de.json, so I don't have to override any in de-DE.json and created a new de-AT.json which overrides the few strings that need to be different. I also adapted the config and it seems that the code de-AT was not satisfying the type, so I ran pnpm generate, but I'm not sure if that fixed it. It would maybe be a good idea to mention how to fix the GeneratedLocale type in the CONTRIBUTING.md section:

npmx.dev/CONTRIBUTING.md

Lines 507 to 517 in 1fd2d53

#### Country variants (advanced)
Most languages only need a single locale file. Country variants are only needed when you want to support regional differences (e.g., `es-ES` for Spain vs `es-419` for Latin America).
If you need country variants:
1. Create a base language file (e.g., `es.json`) with all translations
2. Create country variant files (e.g., `es-ES.json`, `es-419.json`) with only the differing translations
3. Register the base language in `locales` and add variants to `countryLocaleVariants`
See how `es`, `es-ES`, and `es-419` are configured in [config/i18n.ts](./config/i18n.ts) for a complete example.

@vercel
Copy link

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Mar 24, 2026 6:22am
npmx.dev Ready Ready Preview, Comment Mar 24, 2026 6:22am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Mar 24, 2026 6:22am

Request Review

@github-actions
Copy link

github-actions bot commented Mar 24, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/de-DE.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3d6a3c26-6ed9-4435-879d-a295bbe60b8a

📥 Commits

Reviewing files that changed from the base of the PR and between 1fd2d53 and c768716.

📒 Files selected for processing (4)
  • config/i18n.ts
  • i18n/locales/de-AT.json
  • i18n/locales/de-DE.json
  • i18n/locales/de.json

📝 Walkthrough

Walkthrough

This pull request restructures the German i18n locale configuration from a single de-DE base locale to a variant-based system. The config/i18n.ts file was modified to define a de base locale with de-DE and de-AT variant expansions. The de-DE.json file was emptied to contain only a schema reference, whilst new de.json and de-AT.json files were created containing comprehensive German and Austrian German translations respectively.

Possibly related PRs

Suggested reviewers

  • danielroe
  • OrbisK
  • userquin
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the purpose of adding Austrian language support, the approach taken (moving de-DE strings to de.json as a base, creating de-AT.json for Austrian-specific overrides), and mentions relevant changes to the config and type generation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at-at

@ghostdevv ghostdevv added this pull request to the merge queue Mar 24, 2026
Merged via the queue into npmx-dev:main with commit 13cf135 Mar 24, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants