Skip to content

fix(i18n): allow translations for the recharging/vacation page#2248

Merged
ghostdevv merged 1 commit intonpmx-dev:mainfrom
trueberryless:fix/dont-delete-vacation-i18n-section
Mar 23, 2026
Merged

fix(i18n): allow translations for the recharging/vacation page#2248
ghostdevv merged 1 commit intonpmx-dev:mainfrom
trueberryless:fix/dont-delete-vacation-i18n-section

Conversation

@trueberryless
Copy link
Copy Markdown
Contributor

@trueberryless trueberryless commented Mar 23, 2026

🧭 Context

I noticed that the autofix CI always deletes the vacation section for the recharging page because we thought that it probably be deleted before the launch again.

📚 Description

This PR removes this deletion part in the compare translation script as I think we decided that the recharging page will stay, so we should probably also allow translators to translate it 👍

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 23, 2026 8:14pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 23, 2026 8:14pm
npmx-lunaria Ignored Ignored Mar 23, 2026 8:14pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 23, 2026

📝 Walkthrough

Walkthrough

The pull request removes three lines of code from scripts/compare-translations.ts that previously deleted the vacations property from the reference content object when loading en.json. With this removal, the vacations translation subtree is now retained and included in subsequent key comparison operations and synchronisation logic, treating it identically to other reference keys.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description clearly explains the context, rationale, and specific change being made to the translation comparison script.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv changed the title fix(i18n): do not delete vacation section in CI fix(i18n): allow translations for the recharging/vacation page Mar 23, 2026
@ghostdevv ghostdevv added this pull request to the merge queue Mar 23, 2026
Merged via the queue into npmx-dev:main with commit 3e3147d Mar 23, 2026
22 checks passed
@github-actions github-actions bot mentioned this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants