Skip to content

fix: remove duplicate scroll-to-top button on docs page#2229

Merged
ghostdevv merged 2 commits intonpmx-dev:mainfrom
RYGRIT:fix/remove-scroll-to-top-button
Mar 23, 2026
Merged

fix: remove duplicate scroll-to-top button on docs page#2229
ghostdevv merged 2 commits intonpmx-dev:mainfrom
RYGRIT:fix/remove-scroll-to-top-button

Conversation

@RYGRIT
Copy link
Contributor

@RYGRIT RYGRIT commented Mar 23, 2026

🔗 Linked issue

🧭 Context

Since the package container already includes a "Scroll to Top" button, this PR removes the original floating button previously located in the bottom-right corner.

📚 Description

before
image

after
image

@vercel
Copy link

vercel bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Mar 23, 2026 4:33pm
npmx.dev Ready Ready Preview, Comment Mar 23, 2026 4:33pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Mar 23, 2026 4:33pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 23, 2026

📝 Walkthrough

Walkthrough

The pull request modifies the ScrollToTop.client.vue component to update its route exclusion logic. The 'docs' route is added to the excludedRoutes set, which prevents the scroll-to-top button from being displayed when users are navigating within the documentation section. The change affects both the CSS-only rendering path and the JavaScript fallback path.

Possibly related PRs

Suggested reviewers

  • danielroe
  • graphieros
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the context and rationale for removing the scroll-to-top button from the docs page.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/ScrollToTop.client.vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv enabled auto-merge March 23, 2026 16:34
@ghostdevv ghostdevv added this pull request to the merge queue Mar 23, 2026
Merged via the queue into npmx-dev:main with commit d189f59 Mar 23, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants