feat: add a warning when the package license changes by aisiklar · Pull Request #2188 · npmx-dev/npmx.dev

aisiklar · 2026-03-21T23:23:41Z

🔗 Linked issue

🧭 Context

added info/warning beneath the license info, "changed!" if there is a change in the license with additional tooltip which shows info about the change, similar to "from x to y at version a.b".
Also modified the Turkish language support too.

📚 Description

as mentioned in the issue, sometimes license changes and it is important to notify the potential user of the package. This pull request is done to make sure that if there is a change in the license the user will be able to see it and also will get info about the details of the change (like from x license to y license and at version a.b.c)

The following changes are done to the codebase:
modified the [name].vue file: added a new props to LicenseDisplay component.
new composable, useLicenseChanges is written.
In the LicenseDisplay component, changes were made to use this composable and add new element for displaying info about the changed license.
Additionally, en.json and tr-TR.json and schema.json files are modified, to add i18n infrastructure and add Turkish language support (for other languages, additional changes are required)

before:

after:

… language too.

vercel · 2026-03-21T23:23:46Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	Mar 24, 2026 7:52am

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	Mar 24, 2026 7:52am
npmx-lunaria	Ignored		Mar 24, 2026 7:52am

github-actions · 2026-03-21T23:24:27Z

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File	Note
i18n/locales/en.json	Source changed, localizations will be marked as outdated.
i18n/locales/tr-TR.json	Localization changed, will be marked as complete. 🔄️

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

coderabbitai · 2026-03-21T23:25:33Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f18c01ec-cf06-47c2-8752-556bb36b322d

📥 Commits

Reviewing files that changed from the base of the PR and between ecbb660 and b91aab5.

📒 Files selected for processing (1)

app/components/LicenseDisplay.vue

🚧 Files skipped from review as they are similar to previous changes (1)

app/components/LicenseDisplay.vue

📝 Walkthrough

Walkthrough

Adds detection and UI for license changes across package versions. Introduces a new composable useLicenseChanges that fetches npm registry metadata, orders versions by timestamp, and emits a list of license change records (from, to, version). LicenseDisplay.vue gains an optional packageName prop, invokes the composable, builds localized change text, and conditionally renders a warning badge with a tooltip when changes exist. The package detail page passes pkg.name into LicenseDisplay. New i18n keys were added for English and Turkish and i18n/schema.json updated accordingly.

Suggested reviewers

danielroe
alexdln

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The PR description clearly explains the implementation of license change detection and warning UI, aligning with the changeset that adds composables, components, and i18n updates.
Linked Issues check	✅ Passed	The PR successfully implements all core objectives from issue `#1826`: detecting license changes across versions, surfacing a visible indicator near license metadata, and providing contextual details (old/new license and version).
Out of Scope Changes check	✅ Passed	All changes are directly scoped to the license change detection feature: new composable, component enhancements, page template updates, and i18n additions. No extraneous modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ghostdevv

Could you do the style similar to the package size increase warning that we have? #1673 Let me know if you have any questions or need any help!

coderabbitai

Actionable comments posted: 3

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f7c1c88e-8b86-4447-9fdb-bfbc10c1ff70

📥 Commits

Reviewing files that changed from the base of the PR and between 4294ada and bfd9550.

📒 Files selected for processing (6)

app/components/LicenseDisplay.vue
app/composables/useLicenseChanges.ts
app/pages/package/[[org]]/[name].vue
i18n/locales/en.json
i18n/locales/tr-TR.json
i18n/schema.json

app/components/LicenseDisplay.vue

app/composables/useLicenseChanges.ts

aisiklar · 2026-03-23T04:03:28Z

Could you do the style similar to the package size increase warning that we have? #1673 Let me know if you have any questions or need any help!

hi @ghostdevv
thanks for your comment. I will check the link you mentioned and also the comments made by coderabbitai and change accordingly. I will return you in case i have additional questions. Thanks.

ghostdevv · 2026-03-23T04:31:05Z

Awesome! I'll mark this as draft for now, and you can mark it as ready when you want me to take another look!

codecov · 2026-03-24T04:25:59Z

Codecov Report

❌ Patch coverage is 40.00000% with 21 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
app/composables/useLicenseChanges.ts	34.78%	13 Missing and 2 partials ⚠️
app/components/LicenseDisplay.vue	54.54%	5 Missing ⚠️
app/pages/package/[[org]]/[name].vue	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

…sorting versions to date of release

aisiklar · 2026-03-24T05:08:18Z

Hi @ghostdevv
Can you please check again?
I made the style change and also fixed the other issues pointed by bot.
I did NOT rebase on the current state of main, if you want, i can do it and make a new commit. This is my first PR so please advice if I am missing some other things.
Thanks

coderabbitai

Actionable comments posted: 2

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 274b5e5e-8053-43ca-946d-f111b04b96f3

📥 Commits

Reviewing files that changed from the base of the PR and between bfd9550 and ecbb660.

📒 Files selected for processing (5)

app/components/LicenseDisplay.vue
app/composables/useLicenseChanges.ts
i18n/locales/en.json
i18n/locales/tr-TR.json
i18n/schema.json

✅ Files skipped from review due to trivial changes (2)

i18n/locales/en.json
i18n/schema.json

🚧 Files skipped from review as they are similar to previous changes (2)

i18n/locales/tr-TR.json
app/composables/useLicenseChanges.ts

app/components/LicenseDisplay.vue

1826-add a warning and info for license changes. Added support for TR…

3a0543f

… language too.

[autofix.ci] apply automated fixes

bfd9550

aisiklar mentioned this pull request Mar 21, 2026

highlight license changes #1826

Open

3 tasks

ghostdevv changed the title ~~1826-add a warning and info for license changes. Added support for TR language too.~~ feat: add a warning when the package license changes Mar 21, 2026

vercel bot deployed to Preview – npmx.dev March 21, 2026 23:27 View deployment

ghostdevv requested changes Mar 21, 2026

View reviewed changes

coderabbitai bot reviewed Mar 21, 2026

View reviewed changes

app/components/LicenseDisplay.vue Outdated Show resolved Hide resolved

app/components/LicenseDisplay.vue Outdated Show resolved Hide resolved

app/composables/useLicenseChanges.ts Outdated Show resolved Hide resolved

ghostdevv marked this pull request as draft March 23, 2026 04:31

aisiklar and others added 2 commits March 24, 2026 04:22

fix:warning style changed and unintended chars erased

fa52bff

[autofix.ci] apply automated fixes

bd4ebe5

vercel bot deployed to Preview – npmx.dev March 24, 2026 04:25 View deployment

aisiklar and others added 2 commits March 24, 2026 05:02

fix:added TR language support for warning text and changed logic for …

9afe21d

…sorting versions to date of release

[autofix.ci] apply automated fixes

ecbb660

vercel bot deployed to Preview – npmx.dev March 24, 2026 05:06 View deployment

aisiklar marked this pull request as ready for review March 24, 2026 07:13

coderabbitai bot reviewed Mar 24, 2026

View reviewed changes

app/components/LicenseDisplay.vue Outdated Show resolved Hide resolved

app/components/LicenseDisplay.vue Outdated Show resolved Hide resolved

fix: removed the vue-118n import and used autoimported

b91aab5

vercel bot deployed to Preview – npmx.dev March 24, 2026 07:52 View deployment

Uh oh!

Conversation

aisiklar commented Mar 21, 2026

🔗 Linked issue

🧭 Context

📚 Description

Uh oh!

vercel bot commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lunaria Status Overview

Tracked Files

Uh oh!

coderabbitai bot commented Mar 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Suggested reviewers

Uh oh!

ghostdevv left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aisiklar commented Mar 23, 2026

Uh oh!

ghostdevv commented Mar 23, 2026

Uh oh!

codecov bot commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aisiklar commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Mar 21, 2026 •

edited

Loading

github-actions bot commented Mar 21, 2026 •

edited

Loading

coderabbitai bot commented Mar 21, 2026 •

edited

Loading

ghostdevv left a comment •

edited

Loading

codecov bot commented Mar 24, 2026 •

edited

Loading

aisiklar commented Mar 24, 2026 •

edited

Loading