Skip to content

feat(ui): make version colors consistent #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 6 commits into from
Mar 21, 2026
Merged

feat(ui): make version colors consistent #2171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2019184
feat(ui): make version colors consistent
MatteoGabriele Mar 20, 2026
2f9fcc4
test: test for accent class
MatteoGabriele Mar 20, 2026
70c2444
Merge branch 'main' into feat/make-version-colors-consistent
ghostdevv Mar 20, 2026
fd28259
fix: add badge-accent to tag
MatteoGabriele Mar 20, 2026
6fe87ee
Merge branch 'main' into feat/make-version-colors-consistent
MatteoGabriele Mar 20, 2026
57f00d1
Merge branch 'main' into feat/make-version-colors-consistent
ghostdevv Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions app/components/VersionSelector.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ watch(
<span dir="ltr" class="me-1.5">{{ currentVersion }}</span>
<span
v-if="currentVersion === latestVersion"
class="text-xs px-1.5 py-0.5 rounded badge-green font-sans font-medium me-1.5"
class="text-xs px-1.5 py-0.5 rounded badge-accent font-sans font-medium me-1.5"
>
latest
</span>
Expand Down Expand Up @@ -577,7 +577,7 @@ watch(
v-for="tag in group.primaryVersion.tags"
:key="tag"
class="text-xs px-1.5 py-0.5 rounded font-sans font-medium"
:class="tag === 'latest' ? 'badge-green' : 'badge-subtle'"
:class="tag === 'latest' ? 'badge-accent' : 'badge-subtle'"
>
{{ tag }}
</span>
Expand Down Expand Up @@ -613,11 +613,7 @@ watch(
v-for="tag in v.tags"
:key="tag"
class="text-4xs px-1 py-0.5 rounded font-sans font-medium"
:class="
tag === 'latest'
? 'bg-emerald-500/10 text-emerald-400'
: 'bg-bg-muted text-fg-subtle'
"
:class="tag === 'latest' ? 'badge-accent' : 'badge-subtle'"
>
{{ tag }}
</span>
Expand Down
6 changes: 3 additions & 3 deletions test/nuxt/components/VersionSelector.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,9 +511,9 @@ describe('VersionSelector', () => {
// Find the latest tag span
const latestTags = component.findAll('span').filter(s => s.text() === 'latest')
expect(latestTags.length).toBeGreaterThan(0)
// Should have green styling
const hasGreenStyling = latestTags.some(t => t.classes().some(c => c.includes('green')))
expect(hasGreenStyling).toBe(true)
// Should have accent styling
const hasAccentStyle = latestTags.some(t => t.classes().some(c => c.includes('badge-accent')))
expect(hasAccentStyle).toBe(true)
})
})

Expand Down
1 change: 1 addition & 0 deletions uno.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ export default defineConfig({
['badge-purple', 'bg-badge-purple/10 text-badge-purple'],
['badge-pink', 'bg-badge-pink/10 text-badge-pink'],
['badge-subtle', 'bg-bg-subtle text-fg-subtle'],
['badge-accent', 'bg-accent/10 text-accent'],
],
rules: [
// Custom scale for active states
Expand Down
Loading