-
-
Notifications
You must be signed in to change notification settings - Fork 367
feat: display yaml frontmatter as a table #2166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
88d6abc
feat: display yaml frontmatter as a table
RYGRIT 1ff273f
Merge branch 'main' into feat/yaml-frontmatter
ghostdevv fd6dcc7
Merge branch 'main' into feat/yaml-frontmatter
RYGRIT dff1d11
Merge branch 'feat/yaml-frontmatter' of https://github.com/RYGRIT/npm…
RYGRIT 4457658
Merge remote-tracking branch 'origin/main' into feat/yaml-frontmatter
ghostdevv ec1d77e
fix: merge artifact
ghostdevv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
In gray-matter, for input starting with empty YAML frontmatter (---\n---\nBody), doesmatter(content)returndata = {}andcontentstripped of delimiters?💡 Result:
Yes, in gray-matter, for input starting with empty YAML frontmatter (---\n---\nBody), matter(content) returns an object with data = {} (empty object) and content stripped of the frontmatter delimiters (i.e., content = "Body"). The frontmatter between the delimiters is empty (all whitespace/nothing), so the YAML parser returns an empty object, and the delimiters are removed from the content. Additionally, the result includes isEmpty: true (or a truthy value for empty matter, as per v4.0+) and possibly empty property with the original matter string.
Citations:
Always strip frontmatter delimiters even when metadata is empty.
When
matter(content)parses an empty YAML frontmatter block (---\n---\nBody), it returnsdata = {}with the delimiters removed fromcontent. However, the current code only assignsmarkdownBody = bodywhenObject.keys(data).length > 0, leaving the delimiters in place if the frontmatter is empty. These delimiters will then render as horizontal rules (<hr>) when passed tomarked. The table generation should remain conditional, but the body assignment must happen unconditionally after a successful parse.🔧 Proposed fix
try { const { data, content: body } = matter(content) - if (data && Object.keys(data).length > 0) { - frontmatterHtml = renderFrontmatterTable(data) - markdownBody = body - } + markdownBody = body + if (data && Object.keys(data).length > 0) { + frontmatterHtml = renderFrontmatterTable(data) + } } catch {