fix(i18n): update Simplified Chinese and Traditional Chinese translations#2147
fix(i18n): update Simplified Chinese and Traditional Chinese translations#2147ghostdevv merged 3 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
wChenonly
changed the title
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates Simplified and Traditional Chinese localisation files (i18n/locales/zh-CN.json and i18n/locales/zh-TW.json), adding and modifying numerous translation keys across shortcuts, settings (instant search and graph pulse loop), footer/blog, package UI (links, card selection, versions, maintainers, trends, downloads), code viewer binary handling, filters, compare UI, about/pds pages, HTTP error messages (zh-TW), and a new top-level action_bar. Net changes: zh-CN lines changed +51/−10; zh-TW lines changed +129/−18. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2af9e093-b98b-4faf-a337-a7d59ff59dfb
📒 Files selected for processing (2)
i18n/locales/zh-CN.jsoni18n/locales/zh-TW.json
There was a problem hiding this comment.
♻️ Duplicate comments (3)
i18n/locales/zh-TW.json (2)
203-203:⚠️ Potential issue | 🟡 MinorFinish the new
view_onprovider labels.Line 203, Line 205 and Line 206 still end mid-phrase, so the provider menu will render broken standalone labels.
💬 Suggested fix
- "git_repo": "在 Git repository", + "git_repo": "在 Git 儲存庫上檢視", "forgejo": "在 Forgejo 上檢視", - "gitea": "在 Gitea", - "gitee": "在 Gitee", + "gitea": "在 Gitea 上檢視", + "gitee": "在 Gitee 上檢視",Also applies to: 205-206
1350-1350:⚠️ Potential issue | 🟡 MinorKeep the full selection message in every plural branch.
Line 1350 drops the
已選擇prefix in the third branch, so counts above 1 render as just{count} 個套件.💬 Suggested fix
- "selection": "已選擇 0 個套件 | 已選擇 1 個套件 | {count} 個套件", + "selection": "已選擇 0 個套件 | 已選擇 1 個套件 | 已選擇 {count} 個套件",i18n/locales/zh-CN.json (1)
286-286:⚠️ Potential issue | 🟡 MinorRemove the pasted key name from the
refstranslation.Line 286 still contains
grouping_usage_most_usedinside the user-facing copy, so the file count will render corrupted text.💬 Suggested fix
- "refs": "{count} 个引grouping_usage_most_used用 | {count} 个引用", + "refs": "{count} 个引用 | {count} 个引用",
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 80f4b9aa-6b2c-4fab-94ce-588e8c8d33d2
📒 Files selected for processing (2)
i18n/locales/zh-CN.jsoni18n/locales/zh-TW.json
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
i18n/locales/zh-TW.json (1)
1350-1350:⚠️ Potential issue | 🟡 MinorKeep the full selection status in the last plural branch.
Line 1350 drops
已選擇in the final branch, so counts above 1 render as a bare package count instead of a complete selection message.💬 Proposed fix
- "selection": "已選擇 0 個套件 | 已選擇 1 個套件 | {count} 個套件", + "selection": "已選擇 0 個套件 | 已選擇 1 個套件 | 已選擇 {count} 個套件",
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 37c7b3a2-8871-4b5f-a600-3c67790095ff
📒 Files selected for processing (2)
i18n/locales/zh-CN.jsoni18n/locales/zh-TW.json
🚧 Files skipped from review as they are similar to previous changes (1)
- i18n/locales/zh-CN.json
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
i18n/locales/zh-TW.json (2)
1350-1350:⚠️ Potential issue | 🟡 MinorKeep the full selection message in every branch.
The third branch of the pluralisation resolves to just
{count} 個套件, losing the "已選擇" (selected) context that appears in the first two branches. This will render inconsistently in the action bar for counts greater than 1.💬 Suggested fix
- "selection": "已選擇 0 個套件 | 已選擇 1 個套件 | {count} 個套件", + "selection": "已選擇 0 個套件 | 已選擇 1 個套件 | 已選擇 {count} 個套件",
505-506:⚠️ Potential issue | 🟡 MinorNormalise the facet-bar alt text punctuation.
These entries use ASCII full stops (
.) and half-width parentheses, which is inconsistent with the rest of the Traditional Chinese accessibility copy that uses Chinese punctuation (。、（）).💬 Proposed fix
- "facet_bar_general_description": "水平長條圖: {package} 的 {facet} 對比({description}). {facet_analysis} {watermark}.", - "facet_bar_analysis": "{package_name} 值為 {value}." + "facet_bar_general_description": "水平長條圖：{packages} 的 {facet} 對比（{description}）。{facet_analysis} {watermark}。", + "facet_bar_analysis": "{package_name} 值為 {value}。"Note: Also verify the placeholder should be
{packages}(plural) to match the zh-CN version at line 505.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a065f41d-2e95-4be9-b6c6-12dc5b6760cb
📒 Files selected for processing (2)
i18n/locales/zh-CN.jsoni18n/locales/zh-TW.json
ghostdevv
changed the title
|
Thanks for your first contribution, @wChenonly! 💥 We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role. |
2 participants
🔗 Linked issue
🧭 Context
📚 Description
Update Simplified Chinese and Traditional Chinese translate