feat: use i18n for hardcoded strings in components and pages by Sigmabrogz · Pull Request #2134 · npmx-dev/npmx.dev

Sigmabrogz · 2026-03-18T18:09:53Z

Replaced hardcoded strings with i18n translations across the following files:

app/pages/blog/index.vue
app/pages/diff/[[org]]/[packageName]/v/[versionRange].vue
app/components/diff/ViewerPanel.vue
app/components/Package/SkillsModal.vue

Added missing keys to en.json.

vercel · 2026-03-18T18:09:59Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	Mar 19, 2026 8:09am

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	Mar 19, 2026 8:09am
npmx-lunaria	Ignored		Mar 19, 2026 8:09am

github-actions · 2026-03-18T18:10:52Z

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File	Note
i18n/locales/en.json	Source changed, localizations will be marked as outdated.

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

codecov · 2026-03-18T18:17:14Z

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
app/components/diff/ViewerPanel.vue	71.42%	1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

coderabbitai · 2026-03-18T18:19:15Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fd425216-2648-4272-a474-8ee06d712b6d

📥 Commits

Reviewing files that changed from the base of the PR and between ae0348f and f9ac6fc.

📒 Files selected for processing (1)

app/components/diff/ViewerPanel.vue

🚧 Files skipped from review as they are similar to previous changes (1)

app/components/diff/ViewerPanel.vue

📝 Walkthrough

Walkthrough

Replaces hard-coded English UI strings with Vue i18n translation keys across multiple components and pages: Package Skills modal, diff ViewerPanel, blog index, and package diff page. Adds corresponding English translations in i18n/locales/en.json (blog entries, skills method labels, and a files.viewer group plus related compare/file keys). No logic, routing, data flow, or API changes.

Possibly related PRs

feat(i18n): add pds, blog and missing Spanish translations #2085 — Adds and modifies the same i18n translation keys (blog, compare/files, skills/file_counts, files.viewer), indicating direct overlap in localization entries.
feat(i18n): add missing German translations and pluralization #1720 — Adjusts localization usage in the same package diff page (app/pages/diff/[[org]]/[packageName]/v/[versionRange].vue), showing file-level changes to i18n calls.
feat(i18n): complete some zh-CN translation #1868 — Updates locale data for blog and files UI areas (ZH-CN translations) that correspond to the new English keys added here.

Suggested reviewers

danielroe
graphieros

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The pull request description accurately describes the changes made, mentioning specific files and the replacement of hardcoded strings with i18n translations.
Linked Issues check	✅ Passed	All requirements from issue `#2128` are met: hardcoded strings in the four specified files have been replaced with i18n translations and corresponding keys were added to en.json.
Out of Scope Changes check	✅ Passed	All changes are within scope of issue `#2128`. The pull request only adds i18n translations to the specified files and translation keys, with no unrelated modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/components/diff/ViewerPanel.vue (1)
148-148: ⚠️ Potential issue | 🟡 Minor

Several strings remain hardcoded despite having i18n keys available.

The following strings should be localised to complete the i18n work for this component:

Line Current Suggested

148 Options {{ $t('compare.viewer.options') }}

301 View file {{ $t('compare.viewer.view_file') }}

338 View in code browser {{ $t('compare.viewer.view_in_code_browser') }}

348 No content changes detected {{ $t('compare.viewer.no_content_changes') }}

These keys already exist in i18n/locales/en.json (lines 1219, 1225, 1228, 1229).
🔧 Proposed fix
             <span class="i-lucide:settings w-3.5 h-3.5" />
-            Options
+            {{ $t('compare.viewer.options') }}
             <span
           class="px-2 py-1 text-xs text-fg-muted hover:text-fg bg-bg-muted border border-border rounded transition-colors"
           target="_blank"
         >
-          View file
+          {{ $t('compare.viewer.view_file') }}
         </NuxtLink>
           class="text-xs text-fg-muted hover:text-fg underline"
         >
-            View in code browser
+            {{ $t('compare.viewer.view_in_code_browser') }}
           </NuxtLink>
       <div
         v-else-if="diff && diff.hunks.length === 0"
         class="py-8 text-center text-fg-muted text-sm"
       >
-        No content changes detected
+        {{ $t('compare.viewer.no_content_changes') }}
       </div>
Also applies to: 301-301, 338-338, 348-348

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8c3bd668-6049-407a-bf86-541c8f6aa8a9

📥 Commits

Reviewing files that changed from the base of the PR and between 77c4570 and ae0348f.

📒 Files selected for processing (5)

app/components/Package/SkillsModal.vue
app/components/diff/ViewerPanel.vue
app/pages/blog/index.vue
app/pages/diff/[[org]]/[packageName]/v/[versionRange].vue
i18n/locales/en.json

…code review

Sigmabrogz · 2026-03-19T08:07:14Z

I've updated the remaining hardcoded strings in ViewerPanel.vue with their respective i18n keys! Ready for re-review.

MatteoGabriele · 2026-03-19T14:35:24Z

Thanks for jumping on this issue! I've just merged #2140 since it was ready to go, but I appreciate you taking the time to work on it. 🙏

feat: use i18n for hardcoded strings in components and pages

c27d6f5

Closes npmx-dev#2128

[autofix.ci] apply automated fixes

ae0348f

vercel bot deployed to Preview – npmx.dev March 18, 2026 18:13 View deployment

coderabbitai bot reviewed Mar 18, 2026

View reviewed changes

nadaniels mentioned this pull request Mar 18, 2026

fix(i18n): add missing translation keys #2140

Merged

fix(i18n): apply remaining string translations in ViewerPanel as per …

f9ac6fc

…code review

vercel bot deployed to Preview – npmx.dev March 19, 2026 08:09 View deployment

MatteoGabriele closed this Mar 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: use i18n for hardcoded strings in components and pages#2134

feat: use i18n for hardcoded strings in components and pages#2134
Sigmabrogz wants to merge 3 commits intonpmx-dev:mainfrom
Sigmabrogz:fix/issue-2128

Sigmabrogz commented Mar 18, 2026

Uh oh!

vercel bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 18, 2026 •

edited

Loading

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Uh oh!

Sigmabrogz commented Mar 19, 2026

Uh oh!

MatteoGabriele commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Line	Current	Suggested
148	`Options`	`{{ $t('compare.viewer.options') }}`
301	`View file`	`{{ $t('compare.viewer.view_file') }}`
338	`View in code browser`	`{{ $t('compare.viewer.view_in_code_browser') }}`
348	`No content changes detected`	`{{ $t('compare.viewer.no_content_changes') }}`

Uh oh!

Conversation

Sigmabrogz commented Mar 18, 2026

Uh oh!

vercel bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lunaria Status Overview

Tracked Files

Uh oh!

codecov bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Sigmabrogz commented Mar 19, 2026

Uh oh!

MatteoGabriele commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Mar 18, 2026 •

edited

Loading

github-actions bot commented Mar 18, 2026 •

edited

Loading

codecov bot commented Mar 18, 2026 •

edited

Loading

coderabbitai bot commented Mar 18, 2026 •

edited

Loading