Skip to content

fix: use authors hash for bsky author profile endpoint cache key #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
userquin wants to merge 8 commits into from
Closed

fix: use authors hash for bsky author profile endpoint cache key #1975

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
183fb91
fix: use authors hash for bsky author profile endpoint cache key
userquin Mar 7, 2026
d2894c3
chore: fix JWK error
userquin Mar 7, 2026
f27a332
chore: .
userquin Mar 7, 2026
1256ba6
chore: revert JWK changes
userquin Mar 7, 2026
dc27dcc
chore: prevent error loading node oauth client when testing
userquin Mar 7, 2026
b5ec1b5
Revert "chore: prevent error loading node oauth client when testing"
userquin Mar 7, 2026
3104958
chore: wrap `loadJWKs` with `try-catch` block
userquin Mar 7, 2026
3ad466c
chore: protect `oauthClient` usages
userquin Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nuxt.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default defineNuxtConfig({
github: {
orgToken: '',
},
oauthJwkOne: process.env.OAUTH_JWK_ONE || undefined,
oauthJwkOne: process.env.TEST ? '' : process.env.OAUTH_JWK_ONE || undefined,

@coderabbitai coderabbitai Bot Mar 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify which env flags the repo actually uses for tests/CI,
# and whether `process.env.TEST` is the right source of truth.

set -eu

echo "== Test-related env flags in scripts and workflows =="
rg -n -C2 '\b(TEST|VITEST|NODE_ENV)\b' \
  --glob 'package.json' \
  --glob '.github/**/*.yml' \
  --glob '.github/**/*.yaml' \
  --glob '**/*.json' \
  --glob '**/*.yml' \
  --glob '**/*.yaml'

echo
echo "== Current uses of std-env test detection versus raw TEST checks =="
rg -n -C2 '\bisTest\b|\bprocess\.env\.TEST\b' \
  --glob '**/*.{ts,tsx,js,mjs,cjs}'

Repository: npmx-dev/npmx.dev

Length of output: 2502

Replace process.env.TEST with isTest for consistent test environment detection.

The repository's test scripts set NODE_ENV=test, not TEST=true. The code already imports and uses isTest from std-env at line 253 in the same file; it should be reused here instead of checking a raw environment variable that isn't explicitly configured. Using process.env.TEST creates inconsistency and risks disabling the JWK config in the wrong environment.

Suggested change 
-    oauthJwkOne: process.env.TEST ? '' : process.env.OAUTH_JWK_ONE || undefined,
+    oauthJwkOne: isTest ? '' : process.env.OAUTH_JWK_ONE || undefined,
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
oauthJwkOne: process.env.TEST ? '' : process.env.OAUTH_JWK_ONE || undefined,
oauthJwkOne: isTest ? '' : process.env.OAUTH_JWK_ONE || undefined,

// Upstash Redis for distributed OAuth token refresh locking in production
upstash: {
redisRestUrl: process.env.UPSTASH_KV_REST_API_URL || process.env.KV_REST_API_URL || '',
Expand Down
7 changes: 6 additions & 1 deletion server/api/atproto/bluesky-author-profiles.get.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { AuthorSchema } from '#shared/schemas/blog'
import { Client } from '@atproto/lex'
import type { Author, ResolvedAuthor } from '#shared/schemas/blog'
import * as app from '#shared/types/lexicons/app'
import * as crypto from 'node:crypto'

export default defineCachedEventHandler(
async event => {
Expand Down Expand Up @@ -75,7 +76,11 @@ export default defineCachedEventHandler(
maxAge: CACHE_MAX_AGE_ONE_DAY,
getKey: event => {
const { authors } = getQuery(event)
return `author-profiles:${authors ?? 'npmx.dev'}`
if (!authors) {
return 'author-profiles:npmx.dev'
}
const key = crypto.createHash('sha256').update(JSON.stringify(authors)).digest('hex')
return `author-profiles:${key}`
},
},
)
Loading