feat(i18n): add Arabic font support#1511
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe change adds "IBM Plex Sans Arabic" to font stacks and configuration only. In lunaria/styles.ts the root CSS variables 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I updated the PR description to include the screenshots, sorry I missed it at first! FYI, Daniel had mentioned on Discord that there's extra fonts being downloaded and wanted to investigate further before merging. |
Do you have a link 👀 |
|
also tagging Alex for a review since we're changing fonts - not sure if we should add this to the brand page? @alexdln |
|
@ghostdevv I think nope. We use Geist in our logo, banners and og-images. While this one is only for internal content and therefore isn't important for the press |
alexdln
left a comment
There was a problem hiding this comment.
Might be better to use arabic font first, because now user can download bunch of fonts (geist for numbers, geist mono 500 for question mark, geist 600 for dot in tab, IBM mono 400 for arabic text, etc.)
But there still would be lags and minuses, so it's not a recommendation. Overall lgtm
|
After syncing with main and checking the latest preview (the first comment with the link seems to be broken on this pr lol), the duplicate font download seems to be gone - so will merge this for now and we can make any other changes in a follow up 🫡 |

Added a font for Arabic language because the current font does not support Arabic letters (and I guess many other languages?)😅.
Tested this locally and found it to preserve the original font Geist when English text is written in the middle of Arabic text, I suppose this is
unicode-rangeworking properly.Changes Preview
Before:

After:
