Skip to content

feat(i18n): add Arabic font support#1511

Merged
ghostdevv merged 4 commits intonpmx-dev:mainfrom
abaza738:main
Apr 4, 2026
Merged

feat(i18n): add Arabic font support#1511
ghostdevv merged 4 commits intonpmx-dev:mainfrom
abaza738:main

Conversation

@abaza738
Copy link
Copy Markdown
Contributor

@abaza738 abaza738 commented Feb 14, 2026

Added a font for Arabic language because the current font does not support Arabic letters (and I guess many other languages?)😅.
Tested this locally and found it to preserve the original font Geist when English text is written in the middle of Arabic text, I suppose this is unicode-range working properly.

Changes Preview

Before:
image

After:
image

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Apr 4, 2026 9:22pm
npmx.dev Ready Ready Preview, Comment Apr 4, 2026 9:22pm
npmx.dev (canary) Ready Ready Preview, Comment Apr 4, 2026 9:22pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Apr 4, 2026 9:22pm

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 14, 2026

📝 Walkthrough

Walkthrough

The change adds "IBM Plex Sans Arabic" to font stacks and configuration only. In lunaria/styles.ts the root CSS variables --ln-font-body and --ln-font-mono are extended to include "IBM Plex Sans Arabic". nuxt.config.ts gains a fonts.families entry for "IBM Plex Sans Arabic" with weights 400, 500, 600, global rendering enabled and the Arabic subset. uno.config.ts updates theme.font.mono and theme.font.sans to include "IBM Plex Sans Arabic". No other logic was changed.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main
Description check ✅ Passed The pull request description clearly explains the addition of Arabic font support, references testing, and provides visual evidence of the changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you show some screenshots of before/after? @abaza738

@abaza738
Copy link
Copy Markdown
Contributor Author

abaza738 commented Mar 24, 2026

I updated the PR description to include the screenshots, sorry I missed it at first!

FYI, Daniel had mentioned on Discord that there's extra fonts being downloaded and wanted to investigate further before merging.

@ghostdevv
Copy link
Copy Markdown
Contributor

FYI, Daniel had mentioned on Discord that there's extra fonts being downloaded and wanted to investigate further before merging.

Do you have a link 👀

@abaza738
Copy link
Copy Markdown
Contributor Author

@ghostdevv
Copy link
Copy Markdown
Contributor

ah, it does seem to download two files with firefox only being able to show that preview thingy for one 🤔

image

@ghostdevv ghostdevv requested a review from alexdln March 25, 2026 18:14
@ghostdevv
Copy link
Copy Markdown
Contributor

also tagging Alex for a review since we're changing fonts - not sure if we should add this to the brand page? @alexdln

@alexdln
Copy link
Copy Markdown
Member

alexdln commented Mar 25, 2026

@ghostdevv I think nope. We use Geist in our logo, banners and og-images. While this one is only for internal content and therefore isn't important for the press

Copy link
Copy Markdown
Member

@alexdln alexdln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to use arabic font first, because now user can download bunch of fonts (geist for numbers, geist mono 500 for question mark, geist 600 for dot in tab, IBM mono 400 for arabic text, etc.)

But there still would be lags and minuses, so it's not a recommendation. Overall lgtm

@ghostdevv
Copy link
Copy Markdown
Contributor

After syncing with main and checking the latest preview (the first comment with the link seems to be broken on this pr lol), the duplicate font download seems to be gone - so will merge this for now and we can make any other changes in a follow up 🫡

@ghostdevv ghostdevv added this pull request to the merge queue Apr 4, 2026
Merged via the queue into npmx-dev:main with commit e88c6e4 Apr 4, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This has become stale and may be closed soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants