fix: visible focus rendering of footer's privacy policy link#1110
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThis pull request updates styling in Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
263280b to
5f06c2d
Compare
When navigating through the footer elements using the keyboard, the focus rendering for the "Privacy Policy" link differs from other similar links:
Screen.Recording.2026-02-06.at.19.55.04.mov
This happens because the
.min-h-11class is applied only to this specific link, while the other footer links do not use it.Since I'm not sure about the expected footer's rendering I preserved the existing layout by moving the
.min-h-11class from the link itself to its container. This keeps the same minimum height while ensuring consistent focus rendering across all footer links.After the fix:
Screen.Recording.2026-02-06.at.20.04.41.mov