Skip to content

fix: visible focus rendering of footer's privacy policy link#1110

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
julien-deramond:main-jd-fix-footer-privacy-policy-visible-focus-rendering
Feb 6, 2026
Merged

fix: visible focus rendering of footer's privacy policy link#1110
danielroe merged 1 commit intonpmx-dev:mainfrom
julien-deramond:main-jd-fix-footer-privacy-policy-visible-focus-rendering

Conversation

@julien-deramond
Copy link
Copy Markdown
Contributor

When navigating through the footer elements using the keyboard, the focus rendering for the "Privacy Policy" link differs from other similar links:

Screen.Recording.2026-02-06.at.19.55.04.mov

This happens because the .min-h-11 class is applied only to this specific link, while the other footer links do not use it.

Since I'm not sure about the expected footer's rendering I preserved the existing layout by moving the .min-h-11 class from the link itself to its container. This keeps the same minimum height while ensuring consistent focus rendering across all footer links.

After the fix:

Screen.Recording.2026-02-06.at.20.04.41.mov

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 6, 2026 9:19pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 6, 2026 9:19pm
npmx-lunaria Ignored Ignored Feb 6, 2026 9:19pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

This pull request updates styling in app/components/AppFooter.vue. The min-h-11 utility class was removed from the privacy link and added to the parent desktop links container (class changed from hidden sm:flex items-center gap-6 to hidden sm:flex items-center gap-6 min-h-11; privacy link class removed min-h-11). No structural or behavioural changes were made. Two lines added and two lines removed.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the issue with keyboard focus rendering on the Privacy Policy link and describes the solution of moving the min-h-11 class to the container for consistency.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe added this pull request to the merge queue Feb 6, 2026
Merged via the queue into npmx-dev:main with commit bd4b408 Feb 6, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants