-
-
Notifications
You must be signed in to change notification settings - Fork 463
chore: add RTL CSS Checker to autofix #1077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
27e4d19
chore: add RTL CSS Checker to autofix
userquin a330d04
chore: fix border and rounded rules
userquin 0c64c2f
chore: fix RTL preset replacements and improve checker accuracy
userquin 206da4e
chore: fix text-left and text-right adding new tests
userquin 0256f32
chore: fix DownloadAnalitics.vue
userquin 33f8c1b
Merge branch 'main' into add-rtl-css-script
userquin 4ff1fcd
Merge branch 'main' into add-rtl-css-script
danielroe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import type { Dirent } from 'node:fs' | ||
| import { glob, readFile } from 'node:fs/promises' | ||
| import { fileURLToPath } from 'node:url' | ||
| import { resolve } from 'node:path' | ||
| import { createGenerator } from 'unocss' | ||
| import { presetRtl } from '../uno-preset-rtl.ts' | ||
| import { COLORS } from './utils.ts' | ||
| import { presetWind4 } from 'unocss' | ||
|
|
||
| const APP_DIRECTORY = fileURLToPath(new URL('../app', import.meta.url)) | ||
|
|
||
| async function checkFile(path: Dirent): Promise<string | undefined> { | ||
| if (path.isDirectory() || !path.name.endsWith('.vue')) { | ||
| return undefined | ||
| } | ||
|
|
||
| const filename = resolve(APP_DIRECTORY, path.parentPath, path.name) | ||
| const file = await readFile(filename, 'utf-8') | ||
| let idx = -1 | ||
| let line: string | ||
| const warnings = new Map<number, string[]>() | ||
| const uno = await createGenerator({ | ||
| presets: [ | ||
| presetWind4(), | ||
| presetRtl((warning, rule) => { | ||
| let entry = warnings.get(idx) | ||
| if (!entry) { | ||
| entry = [] | ||
| warnings.set(idx, entry) | ||
| } | ||
| const ruleIdx = line.indexOf(rule) | ||
| entry.push( | ||
| `${COLORS.red} ❌ [RTL] ${filename}:${idx}${ruleIdx > -1 ? `:${ruleIdx + 1}` : ''} - ${warning}${COLORS.reset}`, | ||
| ) | ||
| }), | ||
| ], | ||
| }) | ||
| const lines = file.split('\n') | ||
| for (let i = 0; i < lines.length; i++) { | ||
| idx = i + 1 | ||
| line = lines[i] | ||
| await uno.generate(line) | ||
| } | ||
|
|
||
| return warnings.size > 0 ? Array.from(warnings.values()).flat().join('\n') : undefined | ||
| } | ||
|
|
||
| async function check(): Promise<void> { | ||
| const dir = glob('**/*.vue', { withFileTypes: true, cwd: APP_DIRECTORY }) | ||
| let hasErrors = false | ||
| for await (const file of dir) { | ||
| const result = await checkFile(file) | ||
| if (result) { | ||
| hasErrors = true | ||
| // oxlint-disable-next-line no-console -- warn logging | ||
| console.error(result) | ||
| } | ||
| } | ||
|
|
||
| if (hasErrors) { | ||
| process.exit(1) | ||
| } else { | ||
| // oxlint-disable-next-line no-console -- success logging | ||
| console.log(`${COLORS.green}✅ CSS RTL check passed!${COLORS.reset}`) | ||
| } | ||
| } | ||
|
|
||
| check() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| export const COLORS = { | ||
| reset: '\x1b[0m', | ||
| red: '\x1b[31m', | ||
| green: '\x1b[32m', | ||
| yellow: '\x1b[33m', | ||
| magenta: '\x1b[35m', | ||
| cyan: '\x1b[36m', | ||
| } as const |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unhandled promise rejection — add a
.catch()handler.check()returnsPromise<void>. If any file read, glob, or generation throws, the rejection is unhandled. Node will exit with a non-zero code on unhandled rejections, but the error message will be a raw stack trace rather than a clear diagnostic.🛡️ Proposed fix
Based on learnings: "Use error handling patterns consistently".
📝 Committable suggestion