Skip to content

chore: add new tests to reach full test coverage #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2023
Merged

chore: add new tests to reach full test coverage #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,20 @@ test('validate-npm-package-name', function (t) {

// Invalid

t.same(validate(''), {
t.same(validate(null), {
validForNewPackages: false,
validForOldPackages: false,
errors: ['name length must be greater than zero'] })
errors: ['name cannot be null'] })

t.same(validate(undefined), {
validForNewPackages: false,
validForOldPackages: false,
errors: ['name cannot be undefined'] })

t.same(validate(42), {
validForNewPackages: false,
validForOldPackages: false,
errors: ['name must be a string'] })

t.same(validate(''), {
Copy link
Member

@wraithgar wraithgar Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the duplicate for the test that was removed, for those following along.

validForNewPackages: false,
Expand Down