Skip to content

Commit

Permalink
fix: Don't restrict length for commit message footer (#467)
Browse files Browse the repository at this point in the history
<!-- What / Why -->
<!-- Describe the request in detail. What it does and why it's being
changed. -->

Our breaking change footers related to engine changes are often >100
characters, resulting in commitlint CI failures.

<!-- Examples:
  Related to #0
  Depends on #0
  Blocked by #0
  Fixes #0
  Closes #0
-->

Example CI failure:
https://github.com/npm/ssri/actions/runs/10169599799/job/28126863705#step:7:12

Associated PR: npm/ssri#137
  • Loading branch information
hashtagchris committed Aug 5, 2024
1 parent 87d3ed9 commit 6ee703d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions .commitlintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ module.exports = {
'header-max-length': [2, 'always', 80],
'subject-case': [0],
'body-max-line-length': [0],
'footer-max-line-length': [0],
},
}
1 change: 1 addition & 0 deletions lib/content/commitlintrc-js.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ module.exports = {
'header-max-length': [2, 'always', 80],
'subject-case': [0],
'body-max-line-length': [0],
'footer-max-line-length': [0],
},
}
2 changes: 2 additions & 0 deletions tap-snapshots/test/apply/source-snapshots.js.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ module.exports = {
'header-max-length': [2, 'always', 80],
'subject-case': [0],
'body-max-line-length': [0],
'footer-max-line-length': [0],
},
}
Expand Down Expand Up @@ -1455,6 +1456,7 @@ module.exports = {
'header-max-length': [2, 'always', 80],
'subject-case': [0],
'body-max-line-length': [0],
'footer-max-line-length': [0],
},
}
Expand Down

0 comments on commit 6ee703d

Please sign in to comment.