Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE(logs): Write process specific timing file instead of newline delimited json in *_timing.json #456

Closed
Tracked by #443
darcyclarke opened this issue Mar 18, 2022 · 1 comment · Fixed by npm/cli#5581
Closed
Tracked by #443

BREAKING CHANGE(logs): Write process specific timing file instead of newline delimited json in *_timing.json #456

darcyclarke opened this issue Mar 18, 2022 · 1 comment · Fixed by npm/cli#5581
Labels
feature
Milestone
v9.0.0

Comments

@darcyclarke
Copy link
Contributor

No description provided.

@darcyclarke darcyclarke mentioned this issue Mar 18, 2022
Closed
32 tasks
@lukekarrys
Copy link
Contributor

We should also standardize where we write any run specific files (logs, _timing.json, eresolve-report.txt)

@darcyclarke darcyclarke changed the title Write process specific timing file instead of newline delimited json in *_timing.json BREAKING CHANGE(logging): Write process specific timing file instead of newline delimited json in *_timing.json Mar 23, 2022
@darcyclarke darcyclarke changed the title BREAKING CHANGE(logging): Write process specific timing file instead of newline delimited json in *_timing.json BREAKING CHANGE(logs): Write process specific timing file instead of newline delimited json in *_timing.json Mar 23, 2022
@lukekarrys lukekarrys added this to the v9.0.0 milestone Sep 2, 2022
@lukekarrys lukekarrys mentioned this issue Sep 23, 2022
Merged
lukekarrys added a commit to npm/cli that referenced this issue Sep 23, 2022
@lukekarrys
feat: timings are now written alongside debug log files
fe8f1c3 
BREAKING CHANGE: `--timing` file changes:
- When run with the `--timing` flag, `npm` now writes timing data to a
file alongside the debug log data, respecting the `logs-dir` option and
falling back to the cache dir, instead of directly inside `.npm/`.
- The timing file data is no longer newline delimited JSON, and instead
each run will create a uniquely named `<ID>-timing.json` file, with the
`<ID>` portion being the same as the debug log.
- Finally, the data inside the file now has three top level keys,
`metadata`, `timers, and `unfinishedTimers` instead of everything being
a top level key.

Closes npm/statusboard#456
lukekarrys added a commit to npm/cli that referenced this issue Sep 23, 2022
@lukekarrys
feat: timings are now written alongside debug log files
b50ffae 
BREAKING CHANGE: `--timing` file changes:
- When run with the `--timing` flag, `npm` now writes timing data to a
file alongside the debug log data, respecting the `logs-dir` option and
falling back to `<CACHE>/_logs/` dir, instead of directly inside the
cache directory.
- The timing file data is no longer newline delimited JSON, and instead
each run will create a uniquely named `<ID>-timing.json` file, with the
`<ID>` portion being the same as the debug log.
- Finally, the data inside the file now has three top level keys,
`metadata`, `timers, and `unfinishedTimers` instead of everything being
a top level key.

Closes npm/statusboard#456
lukekarrys added a commit to npm/cli that referenced this issue Sep 25, 2022
@lukekarrys
feat: timings are now written alongside debug log files
98d4181 
BREAKING CHANGE: `--timing` file changes:
- When run with the `--timing` flag, `npm` now writes timing data to a
file alongside the debug log data, respecting the `logs-dir` option and
falling back to `<CACHE>/_logs/` dir, instead of directly inside the
cache directory.
- The timing file data is no longer newline delimited JSON, and instead
each run will create a uniquely named `<ID>-timing.json` file, with the
`<ID>` portion being the same as the debug log.
- Finally, the data inside the file now has three top level keys,
`metadata`, `timers, and `unfinishedTimers` instead of everything being
a top level key.

Closes npm/statusboard#456
lukekarrys added a commit to npm/cli that referenced this issue Sep 27, 2022
@lukekarrys
feat: timings are now written alongside debug log files
3445da0 
BREAKING CHANGE: `--timing` file changes:
- When run with the `--timing` flag, `npm` now writes timing data to a
file alongside the debug log data, respecting the `logs-dir` option and
falling back to `<CACHE>/_logs/` dir, instead of directly inside the
cache directory.
- The timing file data is no longer newline delimited JSON, and instead
each run will create a uniquely named `<ID>-timing.json` file, with the
`<ID>` portion being the same as the debug log.
- Finally, the data inside the file now has three top level keys,
`metadata`, `timers, and `unfinishedTimers` instead of everything being
a top level key.

Closes npm/statusboard#456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v9.0.0
Development

Successfully merging a pull request may close this issue.

feat: timings are now written alongside debug log files npm/cli
2 participants
@darcyclarke @lukekarrys