Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task(workspaces): update outdated #303

Closed
3 tasks done
darcyclarke opened this issue Mar 2, 2021 · 4 comments
Closed
3 tasks done

task(workspaces): update outdated #303

darcyclarke opened this issue Mar 2, 2021 · 4 comments
Assignees
@ruyadorno
Milestone
OSS - Sprint 31

Comments

@darcyclarke
Copy link
Contributor

darcyclarke commented Mar 2, 2021 •
edited by ruyadorno
Loading

Exit criteria

  • Coupled to & blocked by #273 - adding filtering to Arborist
  • outdated should be able to operate with a set of workspaces defined
  • Tests are written validating this behavior
  • Documentation is updated to reflect this change (ex. metadata/label showing the degree of workspace support)
@darcyclarke darcyclarke added this to the OSS - Sprint 30 milestone May 10, 2021
ruyadorno added a commit to ruyadorno/cli that referenced this issue May 18, 2021
@ruyadorno
feat(outdated): add workspaces support
26785fb 
- Add listing outdated direct deps of a workspace in `npm outdated`
- Add ability to filter the results of `npm outdated` using `-w` config
- Added tests and docs

Fixes: npm/statusboard#303
ruyadorno added a commit to ruyadorno/cli that referenced this issue May 18, 2021
@ruyadorno
feat(outdated): add workspaces support
50a03e6 
- Add listing outdated direct deps of a workspace in `npm outdated`
- Add ability to filter the results of `npm outdated` using `-w` config
- Added tests and docs

Fixes: npm/statusboard#303
@ruyadorno ruyadorno mentioned this issue May 18, 2021
Closed
ruyadorno added a commit to ruyadorno/cli that referenced this issue May 19, 2021
@ruyadorno
feat(outdated): add workspaces support
5edd03c 
- Add listing outdated direct deps of a workspace in `npm outdated`
- Add ability to filter the results of `npm outdated` using `-w` config
- Added tests and docs

Fixes: npm/statusboard#303
@glen-84
Copy link

glen-84 commented May 21, 2021

@ruyadorno,

Is this supposed to be working now?

image

npm ls doesn't seem to work either.

Windows 10, Node.js 14.17.0.

@glen-84 glen-84 mentioned this issue May 25, 2021
Closed
@ruyadorno
Copy link

hi @glen-84 it would be nice to also see your project level package.json to make sure workspaces are properly configured, is any workspace-functionality working at all in this project? what about running npm run --ws from the root level? it would be nice to also maybe see a result for npm ls, etc

@glen-84
Copy link

glen-84 commented May 25, 2021

@ruyadorno,

I just wrote out all that information and then decided to add a name to the workspace package.json files ... and now it works.

  1. Is this a requirement?
  2. Doesn't the workspaces configuration refer to folder paths/names and not package names?
  3. Why does npm run work without naming the workspace packages?

Thanks for your help.

@glen-84
Copy link

glen-84 commented May 26, 2021 •
edited
Loading

@ruyadorno,

Can you please let me know if the above is a bug, or if adding package names to workspace projects is a requirement?

This will inform my decision on whether to wait for a fix, or add the names.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruyadorno ruyadorno

Labels
None yet
Projects
None yet
Milestone
OSS - Sprint 31
Development

No branches or pull requests
3 participants
@ruyadorno @glen-84 @darcyclarke