feat: better support for cloning forked repos #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashtagchris
changed the title
Tested with `node ./bin/gh.mjs template-oss-fix --install --filter 'name:json-parse-even-better-errors'` after removing `~/projects/npm/json-parse-even-better-errors`
hashtagchris
force-pushed
the
hashtagchris-gh-set-default
branch
from
ffec971 to
5ea4245
Compare
wraithgar
approved these changes
Jul 23, 2024
Merged
hashtagchris
pushed a commit
that referenced
this pull request
Aug 27, 2024
🤖 I have created a release *beep* *boop* --- ## [3.0.0](v2.5.0...v3.0.0) (2024-08-27) ###⚠️ BREAKING CHANGES * `stafftools` now supports node `>=22.0.0` ### Features * [`eb6d5ef`](eb6d5ef) [#139](#139) better support for cloning forked repos (#139) (@hashtagchris) ### Bug Fixes * [`ebc67cf`](ebc67cf) [#144](#144) move node engines to 22 (@hashtagchris) ### Dependencies * [`08d9927`](08d9927) [#135](#135) bump minimatch from 9.0.5 to 10.0.1 (@dependabot[bot]) ### Chores * [`2612ea9`](2612ea9) [#144](#144) run template-oss-apply (@hashtagchris) * [`d5fcc51`](d5fcc51) [#143](#143) bump @npmcli/eslint-config from 4.0.5 to 5.0.0 (@dependabot[bot]) * [`21fe981`](21fe981) [#137](#137) postinstall for dependabot template-oss PR (@hashtagchris) * [`0d227d9`](0d227d9) [#137](#137) bump @npmcli/template-oss from 4.22.0 to 4.23.1 (@dependabot[bot]) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the gh cli operates against the upstream repo when you run commands like
gh pr checkout .... For the purposes of stafftools, we want to operate against the forked repo, so we rungh repo set-default npm/{name}.Tested with
node ./bin/gh.mjs template-oss-fix --install --filter 'name:json-parse-even-better-errors'after removing~/projects/npm/json-parse-even-better-errors. Also tested withnode ./bin/gh.mjs repos clone --filter "name:agent", to ensure clone still works for non-forked repos.References
Change to favor the upstream remote: npm/template-oss#363
npm/json-parse-even-better-errors#65
cli/cli#9261 (comment)
cli/cli#6777