Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] pacote does not add to cache #73

Closed
mjsir911 opened this issue Mar 27, 2021 · 0 comments
Closed

[BUG] pacote does not add to cache #73

mjsir911 opened this issue Mar 27, 2021 · 0 comments

Comments

@mjsir911
Copy link
Contributor

Basically just a rehash of npm/cli#2160, npm is expecting pacote to add to cache & pacote has stopped adding to the cache since the big v10 rewrite

What / Why

Pacote fetcher does not add to the cache anymore! npm is expecting this. is npm wrong? Or is pacote wrong?

When

$ npm cache add yn-3.1.1.tgz --cache=./npm-cache
$ ls npm-cache
ls: cannot access 'npm-cache': No such file or directory

Where

Locally, on my machine (no registry, just tarballs)

I appreciate you taking a look at this, if the answer is just that the npm cache command should add to the cache (which does make sense), then great, would just like to verify that that is not under the purview of pacote
mjsir911 added a commit to mjsir911/cli that referenced this issue Mar 27, 2021
@mjsir911
Explicitly add stream to cache
e05b741 
Pacote doesn't do this automatically anymore

Closes npm/pacote#73 & Closes npm#2160
@mjsir911 mjsir911 mentioned this issue Mar 27, 2021
Closed
mjsir911 added a commit to mjsir911/cli that referenced this issue Mar 27, 2021
@mjsir911
Explicitly add stream to cache
fd2e6bd 
Pacote doesn't do this automatically anymore

Closes npm/pacote#73 & Closes npm#2160
mjsir911 added a commit to mjsir911/cli that referenced this issue Mar 27, 2021
@mjsir911
Explicitly add stream to cache
e328cb9 
Pacote doesn't do this automatically anymore

Closes npm/pacote#73 & Closes npm#2160
mjsir911 added a commit to mjsir911/cli that referenced this issue Mar 27, 2021
@mjsir911
Explicitly add stream to cache
d93af78 
Pacote doesn't do this automatically anymore

Closes npm/pacote#73 & Closes npm#2160
mjsir911 added a commit to mjsir911/cli that referenced this issue Mar 28, 2021
@mjsir911
Explicitly add stream to cache
41a60c8 
Pacote doesn't do this automatically anymore

Closes npm/pacote#73 & Closes npm#2160
mjsir911 added a commit to mjsir911/cli that referenced this issue Apr 1, 2021
@mjsir911
Explicitly add stream to cache
887fdf0 
Pacote doesn't do this automatically anymore

Closes npm/pacote#73 & Closes npm#2160
mjsir911 added a commit to mjsir911/cli that referenced this issue Apr 1, 2021
@mjsir911
Explicitly add stream to cache
0e487d2 
Pacote doesn't do this automatically anymore

Closes npm/pacote#73 & Closes npm#2160
mjsir911 added a commit to mjsir911/pacote that referenced this issue Apr 1, 2021
@mjsir911
Cache the tarballs in pacote
f1ad2d3 
Tell `fetch` not to cache it's downloaded tarballs, leave that to us

Not sure the implications of changing the return type of _istream /
adding a `cacache` to the end of the pipe, too unfamiliar with streams

Fixes npm#73 & Fixes npm/cli#2160

Also see npm/cli#2976 for my first attempt & some discussions as to how
we got here.
@mjsir911 mjsir911 mentioned this issue Apr 1, 2021
Closed
isaacs pushed a commit that referenced this issue Apr 13, 2021
@mjsir911 @isaacs
Cache the tarballs in pacote
dda3ca3 
Tell `fetch` not to cache it's downloaded tarballs, leave that to us

Also see npm/cli#2976 for my first attempt & some discussions as to how
we got here.

Fix: #73
Fix: npm/cli#2160
Close: npm/cli#2976

PR-URL: #74
Credit: @mjsir911
Close: #74
Reviewed-by: @isaacs

EDIT(@isaacs): Updated to add test, allow make-fetch-happen to use the
cache, pipe into cache properly, and avoid cache double-writes.
isaacs pushed a commit that referenced this issue Apr 13, 2021
@mjsir911 @isaacs
Cache the tarballs in pacote
ec60d33 
Tell `fetch` not to cache it's downloaded tarballs, leave that to us

Also see npm/cli#2976 for my first attempt & some discussions as to how
we got here.

Fix: #73
Fix: npm/cli#2160
Close: npm/cli#2976

PR-URL: #74
Credit: @mjsir911
Close: #74
Reviewed-by: @isaacs

EDIT(@isaacs): Updated to add test, allow make-fetch-happen to use the
cache, pipe into cache properly, and avoid cache double-writes.
isaacs pushed a commit that referenced this issue Apr 15, 2021
@mjsir911 @isaacs
Cache the tarballs in pacote
ca170cf 
Tell `fetch` not to cache it's downloaded tarballs, leave that to us

Also see npm/cli#2976 for my first attempt & some discussions as to how
we got here.

Fix: #73
Fix: npm/cli#2160
Close: npm/cli#2976

PR-URL: #74
Credit: @mjsir911
Close: #74
Reviewed-by: @isaacs

EDIT(@isaacs): Updated to add test, allow make-fetch-happen to use the
cache, pipe into cache properly, and avoid cache double-writes.
isaacs pushed a commit that referenced this issue Apr 15, 2021
@mjsir911 @isaacs
Cache the tarballs in pacote
1e737c5 
Tell `fetch` not to cache it's downloaded tarballs, leave that to us

Also see npm/cli#2976 for my first attempt & some discussions as to how
we got here.

Fix: #73
Fix: npm/cli#2160
Close: npm/cli#2976

PR-URL: #74
Credit: @mjsir911
Close: #74
Reviewed-by: @isaacs

EDIT(@isaacs): Updated to add test, allow make-fetch-happen to use the
cache, pipe into cache properly, and avoid cache double-writes.
@isaacs isaacs closed this as completed in 500a34f Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mjsir911