Skip to content

Commit

Permalink
chore: use registry proc-log instead of internal
Browse files Browse the repository at this point in the history
  • Loading branch information
lukekarrys committed Feb 10, 2022
1 parent 146ceab commit e49c14c
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 37 deletions.
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,9 @@ resolved, and other properties, as they are determined.
`0o666`. See "Extracted File Modes" below.
* `dmode` Minimum permission mode for extracted directories. Defaults to
`0o777`. See "Extracted File Modes" below.
* `log` A logger object with methods for various log levels. Typically,
this will be [`npmlog`](http://npm.im/npmlog) in the npm CLI use case,
but if not specified, the default is a logger that emits `'log'` events
on the `process` object.
* `log` A logger object with methods for various log levels. If not
specified, the default is a logger that emits `'log'` events on
the `process` object.
* `preferOnline` Prefer to revalidate cache entries, even when it would not
be strictly necessary. Default `false`.
* `before` When picking a manifest from a packument, only consider
Expand Down
4 changes: 3 additions & 1 deletion lib/fetcher.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const { promisify } = require('util')
const { basename, dirname } = require('path')
const rimraf = promisify(require('rimraf'))
const tar = require('tar')
const procLog = require('./util/proc-log.js')
const procLog = require('proc-log')
const retry = require('promise-retry')
const fsm = require('fs-minipass')
const cacache = require('cacache')
Expand Down Expand Up @@ -90,6 +90,8 @@ class FetcherBase {
// the process's umask setting do its job. but if configured, we do
// respect it.
this.umask = opts.umask || 0

// XXX: BREAKING CHANGE remove option.log and always use proc-log
this.log = opts.log || procLog

this.preferOnline = !!opts.preferOnline
Expand Down
21 changes: 0 additions & 21 deletions lib/util/proc-log.js

This file was deleted.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
"npm-packlist": "^3.0.0",
"npm-pick-manifest": "^6.0.0",
"npm-registry-fetch": "^12.0.0",
"proc-log": "^1.0.0",
"promise-retry": "^2.0.1",
"read-package-json": "^4.1.1",
"read-package-json-fast": "^2.0.1",
Expand Down
11 changes: 0 additions & 11 deletions test/util/proc-log.js

This file was deleted.

0 comments on commit e49c14c

Please sign in to comment.