feat: clean token from logged urls #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/redact-token
branch
from
4aa555f to
5e148f1
Compare
Member
|
So is the eventual idea that the cli use this instead? Should the cli still handle the concern of splitting the string on a ' ' and cleaning it up? |
wraithgar
approved these changes
Mar 22, 2022
Member
wraithgar
left a comment
wraithgar
left a comment
There was a problem hiding this comment.
Looking forward to cleaning up cli code.
Contributor
Author
Yes, this version only replaces within a single string. I have a PR in the cli now that consumes this and does the splitting logic in there still. |
wraithgar
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.