fix: exit handler error on login - #144
Merged
Merged
Conversation
milaninfy
marked this pull request as ready for review
July 31, 2024 17:04
Contributor
|
Yeah iirc that |
Contributor
|
I think this makes sense I tested it locally and it fixes the I think if we run this timeout we should have it be apart of nodes event loop. |
reggi
approved these changes
Sep 20, 2024
reggi
left a comment
reggi
left a comment
Contributor
There was a problem hiding this comment.
ref:false is causing the timer to not abide within the node event loop, and is causing the process to exit early.
Merged
reggi
pushed a commit
that referenced
this pull request
Sep 26, 2024
🤖 I have created a release *beep* *boop* --- ## [11.0.0](v10.0.0...v11.0.0) (2024-09-26) ###⚠️ BREAKING CHANGES * `npm-profile` now supports node `^18.17.0 || >=20.5.0` ### Bug Fixes * [`a0ea10b`](a0ea10b) [#152](#152) align to npm 10 node engine range (@reggi) * [`4ea3f70`](4ea3f70) [#144](#144) exit handler error on login (#144) (@milaninfy) ### Dependencies * [`66bcc40`](66bcc40) [#152](#152) `proc-log@5.0.0` ### Chores * [`8ac1fdb`](8ac1fdb) [#152](#152) run template-oss-apply (@reggi) * [`1fdff2e`](1fdff2e) [#146](#146) bump @npmcli/eslint-config from 4.0.5 to 5.0.0 (@dependabot[bot]) * [`5b3ebbc`](5b3ebbc) [#134](#134) bump @npmcli/template-oss to 4.22.0 (@lukekarrys) * [`6b4558f`](6b4558f) [#147](#147) postinstall for dependabot template-oss PR (@hashtagchris) * [`c644e89`](c644e89) [#147](#147) bump @npmcli/template-oss from 4.23.1 to 4.23.3 (@dependabot[bot]) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the possible cause that the exit handler never called happens is when this timer doesn't keep event loop active when
refis set tofalse. Removing set it to true by default.timers/promises/setTimeout
Fixes: npm/cli#7612