Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove lru-cache #698

Closed
wants to merge 1 commit into from
Closed

deps: remove lru-cache #698

wants to merge 1 commit into from

Conversation

mbtools
Copy link
Contributor

@mbtools mbtools commented Apr 11, 2024

The lru-cache package is out-of-date (6.0.0) but would require a major to bring to latest due to node engine requirements.

This removes the dependency on the lru-cache package. It's replaced by a class in this package (#697).

References

#695
npm/cli#7350

@mbtools mbtools requested a review from a team as a code owner April 11, 2024 19:57
@wraithgar
Copy link
Member

I'm sorry for the confusion. I was asking for this to be in a single PR with two commits. I know it's more than we usually ask of external contributors.

If you want, you can let us worry about it. Go ahead and make the single PR and we'll make a new one off of that in the form we need.

Again, sorry for the extra work.

@wraithgar wraithgar closed this Apr 11, 2024
@mbtools
Copy link
Contributor Author

mbtools commented Apr 12, 2024

Got it. No need to apologize. JS isn't my first language. I'm continuously learning about it and open source practices. 😃

Let's finish the review in #697 and then you can create the new PR as required. 🙏

@mbtools mbtools deleted the lru_package branch April 12, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants