fix NPE if dependencies fields are explicitly null in get-dep-spec #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an NPE that happens when a project doesn't have a dependencies field in it's
package.json
on GitHub private packages repository.In that case, the GitHub repository API returns
dependencies
explicitly tonull
, which means the default value assignment inlib/get-dep-spec.js
doesn't kick in, and the process just crashes with an NPE.This makes
npm audit
in npm 7 crash if you depend on a package hosted on GitHub private packages repository that has any version in it's history with nodependencies
field.This also cannot be fixed by pushing a new version to the repository as old versions will still return
dependencies: null
.This is not a breaking change, and is just a safer behaviour than previously.
Sample response from GitHub private repository
When calling:
https://npm.pkg.github.com/REDACTED_PACKAGE_NAME