This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Change API to support publishing non-directories #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This is a SemVer-major breaking change. Change the interface to `publish(manifest, tarData, opts)` instead of `publish(folder, manifest, opts)`. The npm CLI has to pack the directory in order to print out the list of files anyway, and tying the publish command to _only_ publishing folders makes certain use cases no longer possible.
isaacs
force-pushed
the
isaacs/publish-non-dirs
branch
from
c1780f7
to
fa2b600
Compare
|
I was a few commits behind, rebased onto latest. |
isaacs
added a commit
to npm/cli
that referenced
this pull request
Oct 28, 2020
isaacs
added a commit
to npm/cli
that referenced
this pull request
Oct 28, 2020
isaacs
added a commit
to npm/cli
that referenced
this pull request
Oct 28, 2020
darcyclarke
pushed a commit
to npm/cli
that referenced
this pull request
Nov 3, 2020
Depends on npm/libnpmpublish#16 Credit: @isaacs Close: #2074 Reviewed-by: @nlf
darcyclarke
pushed a commit
to npm/cli
that referenced
this pull request
Nov 3, 2020
Depends on npm/libnpmpublish#16 Credit: @isaacs Close: #2074 Reviewed-by: @nlf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a SemVer-major breaking change.
Change the interface to
publish(manifest, tarData, opts)instead ofpublish(folder, manifest, opts). The npm CLI has to pack thedirectory in order to print out the list of files anyway, and tying the
publish command to only publishing folders makes certain use cases no
longer possible.