This repository was archived by the owner on May 10, 2021. It is now read-only.
fix: resolve parent for non-registry dep on only mode #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a prod dependency
A
and a dev dependencyB
both depend on a dependencyC
that is not installed through a registry (eg. was installed through github), and we are running in production-only mode, theupdateJson
process fails because the parent dependencypackage.json
file cannot be resolved.We ran into this issue while moving from
yarn
tonpm
. Our project used a mix of registry and github installed dependencies. When attempting to runnpm ci --production
, the task failed with anenoent ENOENT: no such file or directory
error when reaching theupdateJson
stage.The PR includes a fix that picks the first parent that is a valid dependency for the mode we are running in.
The test describes the case we ran into.
We tested the fix successfully in our project.
closes: #23