Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] "url.URL is not a constructor" error on Node 6 < v6.13.0 #61

Closed
billneff79 opened this issue Feb 26, 2020 · 1 comment
Closed

[BUG] "url.URL is not a constructor" error on Node 6 < v6.13.0 #61

billneff79 opened this issue Feb 26, 2020 · 1 comment
Assignees
@darcyclarke
Milestone
OSS - Sprint 5

Comments

@billneff79
Copy link

What / Why

The unit tests (and actual usage in the wild) fail with the error:
"url.URL is not a constructor"

When

I run the unit tests or use the package on Node v6 (which seems to be supported?) with a version less than v6.13.0, where the URL constructor was first introduced to Node v6.

Where

All places

How

Current Behavior

  • Run unit tests on Node v6 < v6.13.0 (e.g. v6.12.3) and notice the error

Steps to Reproduce

  • Run unit tests on Node v6 < v6.13.0 (e.g. v6.12.3) and notice the error

Expected Behavior

  • Running unit tests on all versions of Node v6 passes without error

Who

References

Introduced in PR #58
https://github.com/npm/hosted-git-info/pull/58/files#diff-168726dbe96b3ce427e7fedce31bb0bcR112
isaacs added a commit that referenced this issue Feb 26, 2020
@isaacs
fix: Do not attempt to use url.URL when unavailable
bb123d2 
Fix #61

This should not be ported to the latest branch, as Node.js v6 support
was dropped there anyway.
@isaacs isaacs mentioned this issue Feb 26, 2020
Closed
billneff79 added a commit to billneff79/hosted-git-info that referenced this issue Feb 26, 2020
@billneff79
fix: do not use url.URL to support early node 6 and scp-style URLs
2dedc7b 
fix npm#60 and npm#61
@billneff79 billneff79 mentioned this issue Feb 26, 2020
Closed
isaacs added a commit that referenced this issue Feb 26, 2020
@isaacs
fix: Do not attempt to use url.URL when unavailable
2d0bb66 
Fix #61

This should not be ported to the latest branch, as Node.js v6 support
was dropped there anyway.

PR-URL: #62
Credit: @isaacs
Close: #62
Reviewed-by: @isaacs
@darcyclarke darcyclarke self-assigned this Feb 29, 2020
@darcyclarke darcyclarke added this to the OSS - Sprint 5 milestone Feb 29, 2020
darcyclarke added a commit that referenced this issue Feb 29, 2020
@darcyclarke
fix: #61 & #65 addressing issues w/ url.URL implmentation which regre…
5b192c8 
…ssed node 6 support
darcyclarke added a commit that referenced this issue Feb 29, 2020
@darcyclarke
fix: #61 & #65 addressing issues w/ url.URL implmentation which regre…
0aaac77 
…ssed node 6 support
darcyclarke added a commit that referenced this issue Feb 29, 2020
@darcyclarke
fix: #61 & #65 addressing issues w/ url.URL implmentation which regre…
5038b18 
…ssed node 6 support

PR-URL: #66
Credit: @darcyclarke
Close: #66
Reviewed-by: @darcyclarke
@darcyclarke
Copy link
Contributor

darcyclarke commented Feb 29, 2020 •
edited
Loading

This should be fixed by #66 which was landed in [email protected]. We'll try to roll out a cli update as soon as possible which will include this dep update (likely as [email protected])

@JACKEYBANKZ JACKEYBANKZ mentioned this issue Oct 24, 2021
Open
@sync-by-unito sync-by-unito bot mentioned this issue Mar 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darcyclarke darcyclarke

Labels
None yet
Projects
None yet
Milestone
OSS - Sprint 5
Development

No branches or pull requests
2 participants
@darcyclarke @billneff79