fix(arborist): apply root overrides to workspace link nodes #8632
+180
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment in throwing Claude Sonnet 4.5 at the bug described at #8258.
I'm honestly not sure about Claude's fix here. It works insofar as it makes the new tests pass, but I worry that it may be a band-aid that masks other, more fundamental problems with how peer dependencies are resolved. I hope one of the maintainers can take a look and decide whether it has merit.
The test cases here should be valuable, as they confirm that #8258 is a real bug, that it's present in the latest npm, and that it occurs during the build ideal tree step.
References
Related to #8258