fix(exec): look in workspace and root for bin entries #7569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
force-pushed
the
gar/exec-workspace-scope
branch
from
c8467d4
to
88ecda1
Compare
|
no statistically significant performance changes detected timing results
|
wraithgar
force-pushed
the
gar/exec-workspace-scope
branch
from
88ecda1
to
bd0ce6a
Compare
Merged
Thorsmercy
reviewed
Jun 11, 2024
| @@ -54,7 +51,7 @@ class Exec extends BaseCommand { | |||
| localBin = resolve(this.npm.localDir, name, 'node_modules', '.bin') | |||
| // We also need to look for `bin` entries in the workspace package.json | |||
| // libnpmexec will NOT look in the project root for the bin entry | |||
| path = runPath | |||
| pkgPath = runPath | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
nehtech9
reviewed
Jun 20, 2024
| @@ -14,7 +14,7 @@ const getBinFromManifest = require('./get-bin-from-manifest.js') | |||
| const noTTY = require('./no-tty.js') | |||
| const runScript = require('./run-script.js') | |||
| const isWindows = require('./is-windows.js') | |||
| const { dirname, resolve } = require('path') | |||
| const { dirname, resolve } = require('node:path') | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7379