Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils/tar): index access while match is null (#7555) #7556

Merged
merged 1 commit into from
May 29, 2024

Conversation

NormanPerrin
Copy link
Contributor

Details explained in issue #7555

Closes #7555

@NormanPerrin NormanPerrin requested a review from a team as a code owner May 23, 2024 06:55
@wraithgar
Copy link
Member

I'm not sure that issue fully explains how to get into this situation. It mentions

cp -r node_modules package/node_modules

But there's no indication of what's in that directory that's causing this. Once that is known, it will inform what the test will look like for this PR.

lib/utils/tar.js Outdated Show resolved Hide resolved
lib/utils/tar.js Outdated Show resolved Hide resolved
@wraithgar
Copy link
Member

Great! Now it'll just need a test to cover that new code path.

@NormanPerrin
Copy link
Contributor Author

NormanPerrin commented May 25, 2024

@wraithgar

Great! Now it'll just need a test to cover that new code path.

Added 👌🏽

@wraithgar wraithgar merged commit 8f94ae8 into npm:latest May 29, 2024
23 checks passed
@github-actions github-actions bot mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Failed index access on utils/tar.js while trying to publish a package with node_modules
2 participants