Use proc-log for stdout and stderr
#7373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
changed the title
proc-log and @npmcli/run-script deps
lukekarrys
force-pushed
the
lk/proc-log-deps
branch
9 times, most recently
from
09526ae
to
0b77f20
Compare
lukekarrys
changed the title
proc-log and @npmcli/run-script depsproc-log out stdout and stderr
lukekarrys
force-pushed
the
lk/proc-log-deps
branch
from
0b77f20
to
f2e0073
Compare
lukekarrys
changed the title
proc-log out stdout and stderrproc-log for stdout and stderr
wraithgar
reviewed
Apr 15, 2024
lukekarrys
force-pushed
the
lk/proc-log-deps
branch
from
61ea31c
to
dedb25e
Compare
lukekarrys
force-pushed
the
lk/proc-log-deps
branch
2 times, most recently
from
e612ae9
to
d9985cc
Compare
wraithgar
reviewed
Apr 16, 2024
wraithgar
reviewed
Apr 16, 2024
wraithgar
reviewed
Apr 16, 2024
wraithgar
reviewed
Apr 16, 2024
wraithgar
reviewed
Apr 16, 2024
wraithgar
reviewed
Apr 16, 2024
wraithgar
reviewed
Apr 16, 2024
|
|
wraithgar
reviewed
Apr 16, 2024
|
The breaking change commits for libnpmversion and libnpmpack need |
|
I'm not sure what combination of install commands caused |
|
LGTM. update the comment, rebase/squash, and I'll approve it. Thanks for taking it in steps w/ TODOS. |
lukekarrys
force-pushed
the
lk/proc-log-deps
branch
from
fd62344
to
5ce9e08
Compare
BREAKING CHANGE: libnpmexec now emits an output event on process instead of invoking the output function passed in
BREAKING CHANGE: libnpmversion no longer takes a `silent` option to suppress output from `@npmcli/run-script`. That output is now emitted via an `output` event on `process`.
BREAKING CHANGE: libnpmpack no longer takes a `silent` option to suppress output from `@npmcli/run-script`. That output is now emitted via an `output` event on `process`.
lukekarrys
force-pushed
the
lk/proc-log-deps
branch
from
5ce9e08
to
0bd87c4
Compare
|
@wraithgar I added |
wraithgar
approved these changes
Apr 16, 2024
Merged
This was referenced Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
pacote@18deps: bump @npmcli/run-script from 7.0.4 to 8.0.0 pacote#352pacoteIf feat: addFor a later PRtimeandinputproc-log#80 lands we can make theread()related breaking changes here (or in a following PR before the next release) to minimize major versions oflibnpmexec.