Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete max listeners test #7055

Merged
merged 1 commit into from
Dec 4, 2023
Merged

chore: delete max listeners test #7055

merged 1 commit into from
Dec 4, 2023

Conversation

lukekarrys
Copy link
Contributor

This was a bug in Node.js that has been fixed (ref nodejs/node#50136).

Ref #6763

@lukekarrys
chore: delete max listeners test
238e3d7 
This was a bug in Node.js that has been fixed (ref nodejs/node#50136).

Ref #6763
@lukekarrys lukekarrys requested a review from a team as a code owner December 2, 2023 21:38
@ljharb
Copy link
Contributor

ljharb commented Dec 2, 2023

isn't it still valuable to keep the test tho?

@lukekarrys
Copy link
Contributor Author

The test was very flaky and currently skipped with tap.todo. So if it were consistently passing I would want to keep it, but otherwise it's too noisy.

@wraithgar wraithgar merged commit 5a2e334 into latest Dec 4, 2023
16 checks passed
@wraithgar wraithgar deleted the lk/rm-max-listeners-test branch December 4, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukekarrys @ljharb @wraithgar