Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies #6133

Merged
merged 21 commits into from
Feb 7, 2023
Merged

Update Dependencies #6133

merged 21 commits into from
Feb 7, 2023

Conversation

lukekarrys
Copy link
Contributor

No description provided.

@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Feb 6, 2023

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 46.849 ±6.62 21.484 ±0.07 19.754 ±0.29 23.197 ±0.28 3.732 ±0.01 3.821 ±0.01 3.056 ±0.04 14.644 ±0.02 3.007 ±0.02 4.278 ±0.02
#6133 40.346 ±5.16 20.920 ±0.20 19.337 ±0.52 22.514 ±0.77 3.571 ±0.06 3.573 ±0.04 2.870 ±0.06 14.109 ±0.15 2.743 ±0.03 4.386 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 31.585 ±1.88 17.018 ±0.17 15.287 ±0.07 16.368 ±0.66 3.308 ±0.01 3.363 ±0.06 3.000 ±0.04 10.493 ±0.16 2.739 ±0.03 3.862 ±0.03
#6133 28.884 ±0.58 16.615 ±0.13 15.633 ±0.11 16.861 ±0.48 3.329 ±0.04 3.342 ±0.04 2.784 ±0.02 10.738 ±0.05 2.644 ±0.11 3.701 ±0.00

@lukekarrys lukekarrys marked this pull request as ready for review February 7, 2023 00:24
@lukekarrys lukekarrys requested a review from a team as a code owner February 7, 2023 00:24
@lukekarrys lukekarrys requested review from nlf and removed request for a team February 7, 2023 00:24
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two deps are hoisted differently than before, and the hoisting is the correct choice in those cases: minimatch and fs-minipass.

In both cases the newest version is hoisted, and the version that is hoisted is used as a production dep.

All other changes are simply version updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants