Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: switch to actions/checkout@v2 #600

Closed
wants to merge 1 commit into from
Closed

CI: switch to actions/checkout@v2 #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

steps:
# Checkout the npm/cli repo
- uses: actions/checkout@v1.1.0
- uses: actions/checkout@v2

# Installs the specific version of nodejs
- name: Use nodejs 12.x
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:

steps:
# Checkout the npm/cli repo
- uses: actions/checkout@v1
- uses: actions/checkout@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fetch depth defaults to 1 with the new version of actions/checkout. Ordinarily I don't think this would matter, but we've seen some weirdness with depth: 1 checkouts, and I'd rather avoid this for now. We can always adjust this later in the future.

Suggested change
- uses: actions/checkout@v2
- uses: actions/checkout@v2
with:
fetch-depth: 0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the docs on actions/checkout

# Number of commits to fetch. 0 indicates all history.
# Default: 1
fetch-depth: ''


# Installs the specific version of Node.js
- name: Use Node.js ${{ matrix.node-version }}
Expand Down