Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --install-strategy=hoisted|nested|shallow, remove --global-style, --legacy-bundling #5709

Merged
merged 3 commits into from
Oct 18, 2022
Merged

add --install-strategy=hoisted|nested|shallow, remove --global-style, --legacy-bundling #5709

merged 3 commits into from
Oct 18, 2022

Conversation

fritzy
Copy link
Contributor

@fritzy fritzy commented Oct 18, 2022

  • feat: add --install-strategy config, replace --global-style with "shallow" style
  • feat: replace --legacy-bundling with --install-strategy=nested

BREAKING CHANGE:

  • removed --global-style and --legacy-bundling
  • --global now sets --install-strategy=shallow

@fritzy
feat: add --install-strategy config, replace --global-style with
6d82835 
"shallow" style

BREAKING CHANGE: remove --global-style, --global now sets
--install-strategy=shallow
@fritzy fritzy requested a review from a team as a code owner October 18, 2022 08:21
@fritzy
feat: replace --legacy-bundling with --install-strategy=nested
d79c016 
BREAKING CHANGE: removed --legacy-bundling config
@fritzy fritzy force-pushed the fritzy/map-legacy-config branch from 2217a78 to d79c016 Compare October 18, 2022 08:36
@fritzy
Copy link
Contributor Author

fritzy commented Oct 18, 2022

@lukekarrys This can probably be squashed, since I had to readd the deprecated fields in a 3rd commit.

@fritzy fritzy force-pushed the fritzy/map-legacy-config branch from 456fd06 to 78396f1 Compare October 18, 2022 21:44
@lukekarrys lukekarrys merged commit 1574c33 into latest Oct 18, 2022
@lukekarrys lukekarrys deleted the fritzy/map-legacy-config branch October 18, 2022 22:47
lukekarrys pushed a commit that referenced this pull request Oct 19, 2022
@fritzy @lukekarrys
feat: add --install-strategy=hoisted|nested|shallow, deprecate --glob…
de2d33f 
…al-style, --legacy-bundling (#5709)

BREAKING CHANGE: deprecate boolean install flags in favor of `--install-strategy`
* deprecate --global-style, --global now sets --install-strategy=shallow
* deprecate --legacy-bundling, now sets --install-strategy=nested
@github-actions github-actions bot mentioned this pull request Oct 19, 2022
Merged
This was referenced Nov 5, 2022
Closed
Closed
@npm-cli-bot npm-cli-bot mentioned this pull request Nov 16, 2022
Closed
@npm-cli-bot npm-cli-bot mentioned this pull request Nov 30, 2022
Merged
jrabinow added a commit to jrabinow/dotfiles that referenced this pull request Jan 8, 2023
@jrabinow
npm 9 changes
7a82d1e 
Also see https://stackoverflow.com/a/74682436 and
npm/cli#5709
@devinrhode2
Copy link

For anyone crawling release notes, looking for docs on --install-strategy, they are here:
https://docs.npmjs.com/cli/v9/commands/npm-install#install-strategy

@jackromo888 jackromo888 mentioned this pull request Jun 27, 2023
Open
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
@adamlaska adamlaska mentioned this pull request Nov 28, 2023
Open
@kevinjm39 kevinjm39 mentioned this pull request Nov 30, 2023
Open
@LadyK-21 LadyK-21 mentioned this pull request Dec 1, 2023
Open
@jackromo888 jackromo888 mentioned this pull request Dec 1, 2023
Open
@adamlaska adamlaska mentioned this pull request Dec 1, 2023
Open
@kevinjm39 kevinjm39 mentioned this pull request Dec 19, 2023
Open
@Rose2161 Rose2161 mentioned this pull request Mar 14, 2024
Open
@adamlaska adamlaska mentioned this pull request Mar 15, 2024
Open
@jackromo888 jackromo888 mentioned this pull request Mar 17, 2024
Open
@Rose2161 Rose2161 mentioned this pull request Mar 22, 2024
Open
@adamlaska adamlaska mentioned this pull request Mar 22, 2024
Open
@jackromo888 jackromo888 mentioned this pull request Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukekarrys lukekarrys lukekarrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fritzy @devinrhode2 @lukekarrys