Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): remove node-version and npm-version #5691

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

wraithgar
Copy link
Member

BREAKING CHANGE: the node-version and npm-version configs have been
removed.

These are only used sparingly by arborist to determine if optional
dependencies should be installed, and during engines checks (which
are only warnings unless engine-strict is true.

@wraithgar wraithgar requested a review from a team as a code owner October 12, 2022 19:59
@wraithgar
Copy link
Member Author

Closes npm/statusboard#575

@wraithgar
Copy link
Member Author

Didn't see the snapshot. Gotta fix that.

@wraithgar wraithgar force-pushed the gar/rm-node-npm-version branch 3 times, most recently from 5dd596e to 55748be Compare October 13, 2022 14:30
BREAKING CHANGE: the `node-version` and `npm-version` configs have been
removed.

These are only used sparingly by arborist to determine if optional
dependencies should be installed, and during engines checks (which
are only warnings unless `engine-strict` is true.
@wraithgar wraithgar force-pushed the gar/rm-node-npm-version branch from 55748be to f697c50 Compare October 13, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants