Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isaacs/workspace root #3596

Closed
wants to merge 2 commits into from
Closed

Isaacs/workspace root #3596

wants to merge 2 commits into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Jul 30, 2021 •
edited
Loading

Implements npm/rfcs#343

  • add feature to @npmcli/arborist to save .npmrc files in workspace folders when saveWorkspace is true
  • add feature to @npmcli/config to support workspace .npmrc files if present
  • update @npmcli/config and @npmcli/arborist in npm/cli
  • add new config values to cli

References

@isaacs isaacs changed the base branch from latest to release-next July 30, 2021 19:31
@isaacs isaacs force-pushed the isaacs/workspace-root branch from 0de5081 to 556a5bf Compare July 30, 2021 19:32
isaacs added a commit to npm/arborist that referenced this pull request Jul 31, 2021
@isaacs
feat: Save .npmrc files setting workspace-root in workspaces
3b98b42 
Related-to: npm/cli#3596
@isaacs isaacs mentioned this pull request Jul 31, 2021
Closed
isaacs added a commit to npm/config that referenced this pull request Jul 31, 2021
@isaacs
wip: loading/setting workspace-root config, implicit workspace
d2fef1d 
TODO:
- warn when dropping other project configs if ws root is set
- do not allow ws root to be set other than in project or workspace level

Related-to: npm/cli#3596
isaacs added a commit to npm/config that referenced this pull request Jul 31, 2021
@isaacs
feat: workspace-root config, implicit workspace
e13db01 
Related-to: npm/cli#3596
isaacs added a commit to npm/config that referenced this pull request Aug 3, 2021
@isaacs
feat: workspace-root config, implicit workspace
a9fc9e3 
Related-to: npm/cli#3596
isaacs added a commit to npm/config that referenced this pull request Aug 3, 2021
@isaacs
feat: workspace-root config, implicit workspace
8f086a1 
Related-to: npm/cli#3596
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release semver:minor new backwards-compatible feature labels Aug 5, 2021
@darcyclarke darcyclarke added Needs Discussion is pending a discussion Needs Review labels Aug 26, 2021
@wraithgar wraithgar added Release 8.x work is associated with a specific npm 8 release and removed Release 7.x work is associated with a specific npm 7 release labels Oct 7, 2021
@ruyadorno
Copy link
Contributor

This is being implemented as part of:

@ruyadorno ruyadorno closed this Jan 25, 2022
@nlf nlf deleted the isaacs/workspace-root branch March 28, 2022 17:01
@snyk-io snyk-io bot mentioned this pull request Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Discussion is pending a discussion Release 8.x work is associated with a specific npm 8 release semver:minor new backwards-compatible feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isaacs @ruyadorno @wraithgar @darcyclarke