Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.20.3 #3594

Merged
merged 6 commits into from
Jul 29, 2021
Merged

v7.20.3 #3594

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,26 @@
## V7.20.2 (2021-07-27)
## v7.20.3 (2021-07-29)

### BUG FIXES

* [`66dc5f94d`](https://github.com/npm/cli/commit/66dc5f94dfb5bc99c715e075cde1ab9c1ec84a83)
[#3588](https://github.com/npm/cli/issues/3588)
update eresolve explanations for new arborist data provided
* [`99575acab`](https://github.com/npm/cli/commit/99575acab5c93c03c59cb918c7916647b2c0be51)
[#3591](https://github.com/npm/cli/issues/3591)
fix(node_modules): remove duplicated file
([@wraithgar](https://github.com/wraithgar))

### DEPENDENCIES

* [`97cb5ec31`](https://github.com/npm/cli/commit/97cb5ec312e151527ba2aab77ed0307917e1d845)
`@npmcli/[email protected]`:
* Refactor ideal tree building to handle more complicated
peerDependencies use cases.
* Do not modify ideal tree while checking if a peerSet can be placed.
* [`7db1a0a26`](https://github.com/npm/cli/commit/7db1a0a264cf67d2a2a3cdc71bbf09b36dc45075)
chore(deps): `[email protected]` `[email protected]`

## v7.20.2 (2021-07-27)

### DEPENDENCIES

Expand Down
15 changes: 11 additions & 4 deletions lib/utils/explain-eresolve.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,26 +9,33 @@ const { explainEdge, explainNode, printNode } = require('./explain-dep.js')
// The full report (ie, depth=Infinity) is always written to the cache folder
// at ${cache}/eresolve-report.txt along with full json.
const explain = (expl, color, depth) => {
const { edge, current, peerConflict, currentEdge } = expl
const { edge, dep, current, peerConflict, currentEdge } = expl

const out = []
if (edge.from && edge.from.whileInstalling)
out.push('While resolving: ' + printNode(edge.from.whileInstalling, color))
const whileInstalling = dep && dep.whileInstalling ||
current && current.whileInstalling ||
edge && edge.from && edge.from.whileInstalling
if (whileInstalling)
out.push('While resolving: ' + printNode(whileInstalling, color))

// it "should" be impossible for an ERESOLVE explanation to lack both
// current and currentEdge, but better to have a less helpful error
// than a crashing failure.
if (current)
out.push('Found: ' + explainNode(current, depth, color))
else if (peerConflict && peerConflict.current)
out.push('Found: ' + explainNode(peerConflict.current, depth, color))
else if (currentEdge)
out.push('Found: ' + explainEdge(currentEdge, depth, color))
else /* istanbul ignore else - should always have one */ if (edge)
out.push('Found: ' + explainEdge(edge, depth, color))

out.push('\nCould not resolve dependency:\n' +
explainEdge(edge, depth, color))

if (peerConflict) {
const heading = '\nConflicting peer dependency:'
const pc = explainNode(peerConflict, depth, color)
const pc = explainNode(peerConflict.peer, depth, color)
out.push(heading + ' ' + pc)
}

Expand Down
Loading