Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI environment variables to user-agent #249

Closed
wants to merge 10 commits into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Sep 11, 2019

The npm-in-ci header has been sent for some time now by
make-fetch-happen, but User-Agent is more reliably logged and respected
by proxies and CDNs, so that's a better place to put this.

@isaacs isaacs requested a review from a team as a code owner September 11, 2019 16:38
@joeledwards
Copy link

This should be quite effective. Easy to parse out, and it is nice to have the additional detail regarding which CI platform is in use.

Michael Perrotte and others added 9 commits September 24, 2019 15:23
- fix: filter functions and undefined out of makeEnv (@isaacs)
- fix: pack git directories properly (@claudiahdz)
- respect no-optional argument (@cruzdanilo)
PR-URL: #260
Credit: @isaacs
Close: #260
Reviewed-by: @isaacs
It seems that a couple of lines were missed when token.js was [changed
to use figgyPudding][1] which [causes an error][2] when trying to run
that command in certain circumstances.  This patch fixes that error.

[1]: 4cf850d#diff-398ed3b014436a5204583323ea29320b
[2]: https://npm.community/t/npm-token-err-figgypudding-options-cannot-be-modified-use-concat-instead/10288

PR-URL: #259
Credit: @benblank
Close: #259
Reviewed-by: @isaacs
The `npm-in-ci` header has been sent for some time now by
make-fetch-happen, but User-Agent is more reliably logged and respected
by proxies and CDNs, so that's a better place to put this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants